From: David Disseldorp <ddiss@suse.de>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: autofs@vger.kernel.org
Subject: Re: [PATCH] autofs-5.1.9 - fix ldap_parse_page_control() check
Date: Thu, 21 Mar 2024 11:01:42 +1100 [thread overview]
Message-ID: <20240321110142.1b3ddb96@echidna> (raw)
In-Reply-To: <fe523469-beb4-493e-b88a-af7242f27714@molgen.mpg.de>
Hi Paul,
On Wed, 20 Mar 2024 08:51:30 +0100, Paul Menzel wrote:
...
> > /usr/include/ldap.h:2155:25: note: expected 'struct berval **' but
> > argument is of type 'struct berval *'
> > 2155 | ldap_parse_page_control LDAP_P((
>
> I wouldn’t wrap the lines of the pasted parts, and use a more specific
> commit message summary instead of just *fix … check*. Maybe:
>
> ldap_parse_page_control(): Use correct type for @cookie
I'm fine with it either way, but I think the commit summary should
indicate that it's the config-time ldap_parse_page_control() call that's
problematic, not the modules/lookup_ldap.c invocation.
@Ian: feel free to update the commit message as you see fit.
...
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Thanks for the review!
David
prev parent reply other threads:[~2024-03-21 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 0:59 [PATCH] autofs-5.1.9 - fix ldap_parse_page_control() check David Disseldorp
2024-03-20 3:43 ` Ian Kent
2024-04-16 14:23 ` David Disseldorp
2024-04-17 3:10 ` Ian Kent
2024-03-20 7:51 ` Paul Menzel
2024-03-21 0:01 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321110142.1b3ddb96@echidna \
--to=ddiss@suse.de \
--cc=autofs@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).