autofs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karel Zak <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: NeilBrown <neilb-IBi9RG/b67k@public.gmane.org>
Cc: Ian Kent <raven-PKsaG3nR2I+sTnJN9+BGXg@public.gmane.org>,
	autofs mailing list
	<autofs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	util-linux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [autofs PATCH] Add -c option when calling /bin/umount - if supported.
Date: Wed, 7 Jun 2017 17:55:46 +0200	[thread overview]
Message-ID: <20170607155546.os45xr6zv5emhf7g@ws.net.home> (raw)
In-Reply-To: <20170607155202.5zyzuvy6l3fsawkl-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>

On Wed, Jun 07, 2017 at 05:52:02PM +0200, Karel Zak wrote:
> On Wed, Jun 07, 2017 at 10:32:49AM +1000, NeilBrown wrote:
> > 
> > The "-c" option has been supported by umount since util-linux 2.17.
> > It tells umount that the path name is "canonical", meaning no
> > symlinks or ".." etc.
> > This is appropriate for autofs to use and it always uses canonical
> > path names.
> > The advantage of "-c" is that it means umount doesn't need to
> > 'lstat()' the path so much.
> 
> It would be also nice to force systemd to use "umount -c" on shutdown
> to avoid automount storm...

$ git blame -L889,+1 src/core/mount.c
83897d54 (Neil Brown 2017-06-07 22:28:23 +1000 889)         r = exec_command_set(m->control_command, UMOUNT_PATH, m->where, "-c", NULL);

OK.... ;-)

    Karel

-- 
 Karel Zak  <kzak-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-06-07 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-07  0:32 [autofs PATCH] Add -c option when calling /bin/umount - if supported NeilBrown
2017-06-07 15:52 ` Karel Zak
     [not found]   ` <20170607155202.5zyzuvy6l3fsawkl-xkT7n84Rsxv/9pzu0YdTqQ@public.gmane.org>
2017-06-07 15:55     ` Karel Zak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170607155546.os45xr6zv5emhf7g@ws.net.home \
    --to=kzak-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=autofs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=neilb-IBi9RG/b67k@public.gmane.org \
    --cc=raven-PKsaG3nR2I+sTnJN9+BGXg@public.gmane.org \
    --cc=util-linux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).