From: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
To: raven@themaw.net, autofs@vger.kernel.org
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Subject: [PATCH 1/3] autofs: remove possibly misleading /* #define DEBUG */
Date: Sun, 28 Aug 2016 13:05:57 +0900 [thread overview]
Message-ID: <1472357159-1871-1-git-send-email-kusumi.tomohiro@gmail.com> (raw)
Having this in autofs_i.h gives illusion that uncommenting this
enables pr_debug(), but it doesn't enable all the pr_debug() in
autofs because inclusion order matters.
XFS has the same DEBUG macro in its core header fs/xfs/xfs.h,
however XFS seems to have a rule to include this prior to other
XFS headers as well as kernel headers. This is not the case with
autofs, and DEBUG could be enabled via Makefile, so autofs should
just get rid of this comment to make the code less confusing.
It's a comment, so there is literally no functional difference.
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
---
fs/autofs4/autofs_i.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index dd71bd4..4404a22 100644
--- a/fs/autofs4/autofs_i.h
+++ b/fs/autofs4/autofs_i.h
@@ -34,8 +34,6 @@
#include <asm/current.h>
#include <linux/uaccess.h>
-/* #define DEBUG */
-
#ifdef pr_fmt
#undef pr_fmt
#endif
--
2.5.5
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
next reply other threads:[~2016-08-28 4:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 4:05 Tomohiro Kusumi [this message]
2016-08-28 4:05 ` [PATCH 2/3] autofs: refactor ioctl fn vector in iookup_dev_ioctl() Tomohiro Kusumi
2016-08-28 4:05 ` [PATCH 3/3] autofs: fix "fix dev ioctl number range check" Tomohiro Kusumi
-- strict thread matches above, loose matches on Subject: below --
2016-08-31 3:34 [PATCH 1/3] autofs: remove possibly misleading /* #define DEBUG */ Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472357159-1871-1-git-send-email-kusumi.tomohiro@gmail.com \
--to=kusumi.tomohiro@gmail.com \
--cc=autofs@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).