From: Ian Kent <raven@themaw.net>
To: Andreas Steinmetz <ast@domdv.de>, autofs@vger.kernel.org
Subject: Re: [PATCH] prevent autofs to try the wrong IP protocol
Date: Tue, 19 Jan 2016 09:33:49 +0800 [thread overview]
Message-ID: <1453167229.3133.4.camel@themaw.net> (raw)
In-Reply-To: <1453164331.8867.30.camel@domdv.de>
On Tue, 2016-01-19 at 01:45 +0100, Andreas Steinmetz wrote:
> On Mo, 2016-01-18 at 10:36 +0800, Ian Kent wrote:
> > On Sun, 2016-01-17 at 22:14 +0100, Andreas Steinmetz wrote:
> > > [please CC me on replies, I'm not subscribed]
> > >
> > > If the user configures an IPv6 protocol for nfs, autofs tries
> > > IPv4
> > > too,
> > > and vice versa. The attached patch against autofs-5.1.1 prevents
> > > this.
> > >
> > > The additional tries for the wrong IP protocol can be quite
> > > costly
> > > if
> > > e.g. an IPSec tunnel must be brought up.
> >
> > Is this close to what your asking for (not even compile tested)?
> >
> > I'm not certain this won't have any undesired side effects AFAICS
> > it
> > looks ok.
> >
> > autofs-5.1.1 - fix ipv6 proto option handling
> >
>
> Well, I had to fix up your patch slightly to work, at least for my
> IPv6
> use cases. Except for the fact that there are now new version bits in
> use which do hopefully not cause any unwanted side effects it now
> seems
> ok to me. Modified patch of yours is attached.
OK, thanks, I'll have a look at the changes and integrate them.
I think all accesses to the bit fields are bitwise or should be anyway,
I'll have a look around to see if I can see any that could be a
problem.
>
--
To unsubscribe from this list: send the line "unsubscribe autofs" in
prev parent reply other threads:[~2016-01-19 1:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 21:14 [PATCH] prevent autofs to try the wrong IP protocol Andreas Steinmetz
2016-01-18 1:04 ` Ian Kent
2016-01-18 2:36 ` Ian Kent
2016-01-18 7:40 ` Ian Kent
2016-01-19 0:45 ` Andreas Steinmetz
2016-01-19 1:33 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453167229.3133.4.camel@themaw.net \
--to=raven@themaw.net \
--cc=ast@domdv.de \
--cc=autofs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).