From: Paul Moore <paul@paul-moore.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, audit@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_tables: Unbreak audit log reset
Date: Wed, 6 Sep 2023 19:25:19 -0400 [thread overview]
Message-ID: <CAHC9VhTGhTdaRpQj8sQZLeibWAA=2_SyUkSwPQvp2BLSBy3JGg@mail.gmail.com> (raw)
In-Reply-To: <ZPkE1VyCX1BNc76q@calendula>
On Wed, Sep 6, 2023 at 7:01 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Sep 06, 2023 at 06:41:13PM -0400, Paul Moore wrote:
> > On Wed, Sep 6, 2023 at 6:21 PM Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Wed, Sep 06, 2023 at 11:39:41PM +0200, Phil Sutter wrote:
> > > > On Wed, Sep 06, 2023 at 03:56:41PM -0400, Paul Moore wrote:
> > > [...]
> > > > > If it is a bug, please submit a fix for this as soon as possible Pablo.
> > > >
> > > > Thanks for your support, but I can take over, too. The number of
> > > > notifications emitted even for a small ruleset is not ideal, also. It's
> > > > just a bit sad that I ACKed the patch already and so it went out the
> > > > door. Florian, can we still put a veto there?
> > >
> > > Phil, kernel was crashing after your patch, this was resulting in a
> > > kernel panic when running tests here. I had to revert your patches
> > > locally to keep running tests.
> > >
> > > Please, just send an incremental fix to adjust the idx, revert will
> > > leave things in worse state.
> >
> > If we can get a fix out soon then I'm fine with that, if we can't get
> > a fix out soon then a revert may be wise.
>
> I believe it should be possible to fix this in the next -rc, which
> should be quick. If Phil is busy I will jump on this and I will keep
> you on Cc so you and Richard can review.
Great, thank you.
> I apologize for forgetting to Cc you in first place.
No worries :)
> > > Audit does not show chains either, which is not very useful to locate
> > > what where exactly the rules have been reset, but that can probably
> > > discussed in net-next. Richard provided a way to extend this if audit
> > > maintainer find it useful too.
> >
> > Richard was correct in saying that new fields must be added to the end
> > of the record. The only correction I would make to Richard's comments
> > is that we tend to prefer that if a field is present in a record, it
> > is always present in a record; if there is no useful information to
> > log in that field, a "?" can be substituted for the value (e.g.
> > "nftfield=?").
>
> Thanks for clarification, hopefully this will help to explore
> extensions to include chain information in the logs. I think that
> might help users to understand better the kind of updated that
> happened in the Netfilter subsystem.
Great, I'll look forward to the patches.
--
paul-moore.com
next prev parent reply other threads:[~2023-09-06 23:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230906094202.1712-1-pablo@netfilter.org>
2023-09-06 11:32 ` [PATCH nf] netfilter: nf_tables: Unbreak audit log reset Phil Sutter
2023-09-06 11:47 ` Pablo Neira Ayuso
2023-09-06 17:08 ` Phil Sutter
2023-09-06 18:46 ` Pablo Neira Ayuso
2023-09-06 19:56 ` Paul Moore
2023-09-06 21:39 ` Phil Sutter
2023-09-06 22:21 ` Pablo Neira Ayuso
2023-09-06 22:41 ` Paul Moore
2023-09-06 23:01 ` Pablo Neira Ayuso
2023-09-06 23:25 ` Paul Moore [this message]
2023-09-06 22:36 ` Paul Moore
2023-09-06 18:20 ` Richard Guy Briggs
2023-09-06 18:22 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhTGhTdaRpQj8sQZLeibWAA=2_SyUkSwPQvp2BLSBy3JGg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).