From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, Florian Westphal <fw@strlen.de>,
audit@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
Richard Guy Briggs <rgb@redhat.com>
Subject: [nf PATCH 0/3] Review nf_tables audit logging
Date: Sat, 23 Sep 2023 03:53:48 +0200 [thread overview]
Message-ID: <20230923015351.15707-1-phil@nwl.cc> (raw)
When working on locking for reset commands, some audit log calls had to
be adjusted as well. This series deals with the "fallout" from adding
tests for the changed log calls, dealing with the uncovered issues and
adding more tests.
Patch 1 adds more testing to nft_audit.sh for commands which are
unproblematic.
Patch 2 deals with (likely) leftovers from audit log flood prevention in
commit c520292f29b80 ("audit: log nftables configuration change events
once per table").
Patch 3 changes logging for object reset requests to happen once per
table (if skb size is sufficient) and thereby aligns output with object
add requests. As a side-effect, logging is fixed to happen after the
actual reset has succeeded, not before.
NOTE: This whole series probably depends on the reset locking series[1]
submitted earlier, but there's no functional connection and reviews
should happen independently.
[1] https://lore.kernel.org/netfilter-devel/20230923013807.11398-1-phil@nwl.cc/
Phil Sutter (3):
selftests: netfilter: Extend nft_audit.sh
netfilter: nf_tables: Deduplicate nft_register_obj audit logs
netfilter: nf_tables: Audit log object reset once per table
net/netfilter/nf_tables_api.c | 95 +++++-----
.../testing/selftests/netfilter/nft_audit.sh | 163 ++++++++++++++++--
2 files changed, 203 insertions(+), 55 deletions(-)
--
2.41.0
next reply other threads:[~2023-09-23 1:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 1:53 Phil Sutter [this message]
2023-09-23 1:53 ` [nf PATCH 1/3] selftests: netfilter: Extend nft_audit.sh Phil Sutter
2023-09-23 1:53 ` [nf PATCH 2/3] netfilter: nf_tables: Deduplicate nft_register_obj audit logs Phil Sutter
2023-09-27 19:41 ` Pablo Neira Ayuso
2023-09-28 14:48 ` Phil Sutter
2023-09-28 19:14 ` Pablo Neira Ayuso
2023-09-28 1:37 ` Richard Guy Briggs
2023-10-03 17:50 ` Paul Moore
2023-09-23 1:53 ` [nf PATCH 3/3] netfilter: nf_tables: Audit log object reset once per table Phil Sutter
2023-09-28 17:02 ` Richard Guy Briggs
2023-10-03 17:51 ` Paul Moore
2023-10-03 20:48 ` Florian Westphal
2023-09-26 21:24 ` [nf PATCH 0/3] Review nf_tables audit logging Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230923015351.15707-1-phil@nwl.cc \
--to=phil@nwl.cc \
--cc=audit@vger.kernel.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).