From: Atul Kumar Pant <atulpant.linux@gmail.com>
To: Paul Moore <paul@paul-moore.com>
Cc: eparis@redhat.com, audit@vger.kernel.org,
linux-kernel@vger.kernel.org, shuah@kernel.org
Subject: Re: [PATCH v1] kernel: auditsc: Removes use of assignment in if condition and moves open brace following function definitions to the next line.
Date: Wed, 16 Aug 2023 08:28:39 +0530 [thread overview]
Message-ID: <20230816025839.GE57274@atom0118> (raw)
In-Reply-To: <CAHC9VhSQ9FsxF2rg57B-V5f23OKAA-uCHb1iOkCiTuNeTXHMbg@mail.gmail.com>
On Tue, Aug 15, 2023 at 06:14:25PM -0400, Paul Moore wrote:
> On Tue, Aug 15, 2023 at 6:10 PM Paul Moore <paul@paul-moore.com> wrote:
> >
> > On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@gmail.com> wrote:
> > >
> > > The patch fixes following checkpatch.pl issue:
> > > ERROR: open brace '{' following function definitions go on the next line
> > > ERROR: do not use assignment in if condition
> > >
> > > Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> > > ---
> > > kernel/auditsc.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > Merged into audit/next, thanks.
>
> I also wanted to say that I changed the subject line to "audit:
> cleanup function braces and assignment-in-if-condition", what you had
> written was far too long for a subject line. A subject line should be
> brief and does not need to be a full sentence, in fact it probably
> should *not* be a full sentence.
>
Thank you for the comments. I agree with your point on subject line
and will follow your advice in my next patches.
> --
> paul-moore.com
prev parent reply other threads:[~2023-08-16 2:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 20:46 [PATCH v1] kernel: auditsc: Removes use of assignment in if condition and moves open brace following function definitions to the next line Atul Kumar Pant
2023-08-15 22:10 ` Paul Moore
2023-08-15 22:14 ` Paul Moore
2023-08-16 2:58 ` Atul Kumar Pant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230816025839.GE57274@atom0118 \
--to=atulpant.linux@gmail.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).