From: Xiu Jianfeng <xiujianfeng@huaweicloud.com>
To: paul@paul-moore.com, eparis@redhat.com
Cc: audit@vger.kernel.org, xiujianfeng@huawei.com
Subject: [PATCH -next] audit: remove out-of-date comment in auditd_reset()
Date: Fri, 4 Aug 2023 09:41:55 +0000 [thread overview]
Message-ID: <20230804094155.283766-1-xiujianfeng@huaweicloud.com> (raw)
From: Xiu Jianfeng <xiujianfeng@huawei.com>
Since commit 48d0e023af97 ("audit: fix the RCU locking for the
auditd_connection structure"), auditd_conn is changed to a global
pointor protected by RCU, and doesn't call auditd_set() here, which
makes the comment don't match the code, so remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
kernel/audit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/audit.c b/kernel/audit.c
index 45b2fb1e45af..0905750779a4 100644
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -640,7 +640,6 @@ static void auditd_reset(const struct auditd_connection *ac)
struct sk_buff *skb;
struct auditd_connection *ac_old;
- /* if it isn't already broken, break the connection */
spin_lock_irqsave(&auditd_conn_lock, flags);
ac_old = rcu_dereference_protected(auditd_conn,
lockdep_is_held(&auditd_conn_lock));
--
2.34.1
next reply other threads:[~2023-08-04 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:41 Xiu Jianfeng [this message]
2023-08-07 18:20 ` [PATCH -next] audit: remove out-of-date comment in auditd_reset() Paul Moore
2023-08-08 0:56 ` xiujianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804094155.283766-1-xiujianfeng@huaweicloud.com \
--to=xiujianfeng@huaweicloud.com \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=paul@paul-moore.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).