From: Sowmiya Sree Elavalagan <quic_ssreeela@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH v2]wifi: ath12k: Add firmware coredump collection support
Date: Mon, 25 Mar 2024 12:21:47 +0530 [thread overview]
Message-ID: <f690a1f8-09f8-a27c-e1be-fc6c76ea3456@quicinc.com> (raw)
In-Reply-To: <bec0c3f9220c5084f163a39355499bcc7a32da36.camel@sipsolutions.net>
On 3/22/2024 9:32 PM, Johannes Berg wrote:
> On Fri, 2024-03-22 at 11:12 +0530, Sowmiya Sree Elavalagan wrote:
>>
>> +config ATH12K_COREDUMP
>> + bool "ath12k coredump"
>> + depends on ATH12K
>> + select WANT_DEV_COREDUMP
>> + help
>> + Enable ath12k coredump collection
>> +
>> + If unsure, say Y to make it easier to debug problems. But if
>> + you want optimal performance choose N.
>
> Why would having the hooks to dump affect performance? Surely you don't
> expect to be doing it much?
>
> Also I'm impressed - 55MB seems like a lot :)
>
> johannes
>
Hi Johannes,
As per the current design it shouldn't affect performance, here we collect the dump and queue the work of uploading using a work queue and trigger core restart. But according to earlier design we postpone the core restart until the dump has been uploaded. I will remove the statement on performance impact in my next version.
Firmware team requires all the memory regions to be dumped for easier debugging. This holds 55 MB only in case of high memory profile ( >= 1 GB). We haven't enabled any other low memory profile in upstream.
Thanks,
Sowmiya Sree
prev parent reply other threads:[~2024-03-25 6:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 5:42 [PATCH v2]wifi: ath12k: Add firmware coredump collection support Sowmiya Sree Elavalagan
2024-03-22 15:44 ` Jeff Johnson
2024-03-25 6:46 ` Sowmiya Sree Elavalagan
2024-03-22 16:02 ` Johannes Berg
2024-03-25 6:51 ` Sowmiya Sree Elavalagan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f690a1f8-09f8-a27c-e1be-fc6c76ea3456@quicinc.com \
--to=quic_ssreeela@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).