From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Rameshkumar Sundaram <quic_ramess@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH v5 07/12] wifi: ath12k: Cache vdev configs before vdev create
Date: Mon, 25 Mar 2024 11:13:57 -0700 [thread overview]
Message-ID: <bb630d5f-b1f4-4b21-93c4-ed80475582d0@quicinc.com> (raw)
In-Reply-To: <a08b4b7a-7afc-4b1a-92f0-3eca65017175@quicinc.com>
On 3/25/2024 10:49 AM, Rameshkumar Sundaram wrote:
> On 3/22/2024 2:34 AM, Jeff Johnson wrote:
>> On 3/20/2024 12:09 PM, Rameshkumar Sundaram wrote:
>>> + struct ath12k_vif_cache cache;
>>
>> in my v4 comment I had suggested that this cache be a pointer.
>> instead you chose to add pointers to the subordinate records within the cache.
>> why take that approach?
>>
> Thought of making the actual cache objects as pointers, instead of
> allocating memory for all type(key,tx) of caches during vdev create itself.
> So that well allocate required cache alone if needed. Thoughts ?
There is a tradeoff here.
This cache is temporary, but the allocation exists for the lifetime of the
struct. So by having a single pointer here you only waste one pointer, but at
the expense that for each object type you have to see if the cache is already
present, and if not, then allocate the cache.
I'm OK either way, but just wanted to point out that the current approach
wastes more memory when the cache isn't needed.
/jeff
next prev parent reply other threads:[~2024-03-25 18:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 19:09 [PATCH v5 00/12] wifi: ath12k: Add single wiphy support Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 01/12] wifi: ath12k: add multiple radio support in a single MAC HW un/register Rameshkumar Sundaram
2024-03-20 21:35 ` Jeff Johnson
2024-03-20 19:09 ` [PATCH v5 02/12] wifi: ath12k: Modify add and remove chanctx ops for single wiphy support Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 03/12] wifi: ath12k: modify ath12k mac start/stop ops for single wiphy Rameshkumar Sundaram
2024-03-20 21:41 ` Jeff Johnson
2024-03-20 19:09 ` [PATCH v5 04/12] wifi: ath12k: vdev statemachine changes " Rameshkumar Sundaram
2024-03-20 21:52 ` Jeff Johnson
2024-03-20 19:09 ` [PATCH v5 05/12] wifi: ath12k: scan " Rameshkumar Sundaram
2024-03-21 19:54 ` Jeff Johnson
2024-03-25 15:24 ` Rameshkumar Sundaram
2024-03-25 15:33 ` Jeff Johnson
2024-03-25 16:27 ` Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 06/12] wifi: ath12k: fetch correct radio based on vdev status Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 07/12] wifi: ath12k: Cache vdev configs before vdev create Rameshkumar Sundaram
2024-03-21 21:04 ` Jeff Johnson
2024-03-25 17:49 ` Rameshkumar Sundaram
2024-03-25 18:13 ` Jeff Johnson [this message]
2024-03-20 19:09 ` [PATCH v5 08/12] wifi: ath12k: Add additional checks for vif and sta iterators Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 09/12] wifi: ath12k: modify regulatory support for single wiphy architecture Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 10/12] wifi: ath12k: Modify set and get antenna mac ops for single wiphy Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 11/12] wifi: ath12k: Modify rts threshold mac op " Rameshkumar Sundaram
2024-03-20 19:09 ` [PATCH v5 12/12] wifi: ath12k: support get_survey " Rameshkumar Sundaram
2024-03-21 21:08 ` Jeff Johnson
2024-03-20 21:00 ` [PATCH v5 00/12] wifi: ath12k: Add single wiphy support Jeff Johnson
2024-03-25 17:56 ` Rameshkumar Sundaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb630d5f-b1f4-4b21-93c4-ed80475582d0@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_ramess@quicinc.com \
--cc=quic_srirrama@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).