From: "Thiraviyam Mariyappan (Temp)" <tmariyap@qti.qualcomm.com>
To: "Jeff Johnson (QUIC)" <quic_jjohnson@quicinc.com>,
"Thiraviyam Mariyappan (Temp) (QUIC)" <quic_tmariyap@quicinc.com>,
"ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wifi: ath12k: remove reserve member of wbm completion structure
Date: Tue, 5 Mar 2024 09:05:40 +0000 [thread overview]
Message-ID: <CH3PR02MB9068432A870F6DE95DF54243F9222@CH3PR02MB9068.namprd02.prod.outlook.com> (raw)
In-Reply-To: <6a91daf9-76ea-4379-8b12-1b9cb23b3869@quicinc.com>
> -----Original Message-----
> From: Jeff Johnson (QUIC) <quic_jjohnson@quicinc.com>
> Sent: Friday, March 1, 2024 10:23 PM
> To: Thiraviyam Mariyappan (Temp) (QUIC) <quic_tmariyap@quicinc.com>;
> ath12k@lists.infradead.org
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH] wifi: ath12k: remove reserve member of wbm
> completion structure
>
> On 3/1/2024 1:19 AM, quic_tmariyap@quicinc.com wrote:
> > From: Thiraviyam Mariyappan <quic_tmariyap@quicinc.com>
> >
> > In tx completion, status desc obtained from offsetting the address
> > from wbm ring. Having reserved 8 bytes in status desc offsets the
> > address twice and read the values from the incorrect address.
> > So, removing the reserved 8 bytes from wbm completion structure.
>
> Why not instead remove the addition of
> HTT_TX_WBM_COMP_STATUS_OFFSET in
> ath12k_dp_tx_process_htt_tx_complete()?
Similar to ath11k, removed this member from the structure. Will check and address in next patch version.
>
> That would remove an unnecessary operation in the data path.
>
> >
> > Also this patch is applicable for WCN7850.
> >
> > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-
> QCAHKSWPL_SILICONZ-1
> >
> > Signed-off-by: Thiraviyam Mariyappan <quic_tmariyap@quicinc.com>
> > ---
> > drivers/net/wireless/ath/ath12k/dp.h | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath12k/dp.h
> > b/drivers/net/wireless/ath/ath12k/dp.h
> > index eb2dd408e081..d01fc0b0c9a5 100644
> > --- a/drivers/net/wireless/ath/ath12k/dp.h
> > +++ b/drivers/net/wireless/ath/ath12k/dp.h
> > @@ -387,7 +387,6 @@ struct ath12k_dp {
> > #define HTT_TX_WBM_COMP_INFO2_ACK_RSSI
> GENMASK(31, 24)
> >
> > struct htt_tx_wbm_completion {
> > - __le32 rsvd0[2];
> > __le32 info0;
> > __le32 info1;
> > __le32 info2;
prev parent reply other threads:[~2024-03-05 9:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 9:19 [PATCH] wifi: ath12k: remove reserve member of wbm completion structure quic_tmariyap
2024-03-01 16:53 ` Jeff Johnson
2024-03-05 9:05 ` Thiraviyam Mariyappan (Temp) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH3PR02MB9068432A870F6DE95DF54243F9222@CH3PR02MB9068.namprd02.prod.outlook.com \
--to=tmariyap@qti.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_tmariyap@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).