ath12k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Lingbo Kong <quic_lingbok@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 0/4] wifi: ath12k: implement some functionalities through reading ACPI Table
Date: Wed, 17 Jan 2024 13:34:06 +0200	[thread overview]
Message-ID: <87ply05h3l.fsf@kernel.org> (raw)
In-Reply-To: <20231013114434.81648-1-quic_lingbok@quicinc.com> (Lingbo Kong's message of "Fri, 13 Oct 2023 07:44:30 -0400")

Lingbo Kong <quic_lingbok@quicinc.com> writes:

> Through reading ACPI table, implement Time-Average-SAR(TAS), BIOS SAR,
> configuration of CCA threshold and band edge channel power functionalities.

The coding style felt more like for a vendor driver style than upstream
driver so I made quite a lot of changes, too many to list. But for
example I did changes in naming, code compiled only if CONFIG_ACPI is
enabled and whitespace cleanup.

The updated patches are here:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=98dbc0c37b480117959221cafa6326e54667a53a
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=c3d84c46ff4029fdfe15036be4f0a0d1839d31c6
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=04ec37eb823d9d9cba01531a938c53e8a142486f
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=fdd99edcb8ce2433fd243b5ae1b57668eab48ef0

I still have at least few things to do which I'll try to do soon:

o find a correct place to call register()&unregister()

o move wmi functions up in wmi.c

o consolidate wmi functions into two functions? (duplicated code)

I'll let you know once I'm done. As I don't have any device with these
ACPI settings I would need help with testing.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


      parent reply	other threads:[~2024-01-17 11:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-13 11:44 [PATCH v7 0/4] wifi: ath12k: implement some functionalities through reading ACPI Table Lingbo Kong
2023-10-13 11:44 ` [PATCH v7 1/4] wifi: ath12k: add TAS capability for WCN7850 Lingbo Kong
2023-10-13 18:47   ` Jeff Johnson
2023-10-13 11:44 ` [PATCH v7 2/4] wifi: ath12k: add BIOS SAR " Lingbo Kong
2023-10-13 18:47   ` Jeff Johnson
2023-10-13 11:44 ` [PATCH v7 3/4] wifi: ath12k: add adjust configuration of CCA threshold value " Lingbo Kong
2023-10-13 18:47   ` Jeff Johnson
2023-10-13 11:44 ` [PATCH v7 4/4] wifi: ath12k: add set band edge channel power " Lingbo Kong
2023-10-13 18:47   ` Jeff Johnson
2024-01-17 11:34 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ply05h3l.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_lingbok@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).