From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS
Date: Mon, 13 May 2024 16:31:28 -0700 [thread overview]
Message-ID: <7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com> (raw)
In-Reply-To: <20240511013644.3103905-3-quic_periyasa@quicinc.com>
On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote:
> The current value of the MAX_RADIOS define is 3. However, this value is
> incorrect as the maximum number of radios supported by all devices does
> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2.
Use imperative tense: Therefore, modify ...
What is the observed problem, if any, with the current code?
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
> index 496866673aea..27bec3800bff 100644
> --- a/drivers/net/wireless/ath/ath12k/wmi.h
> +++ b/drivers/net/wireless/ath/ath12k/wmi.h
> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
> __le32 buf_len;
> } __packed;
>
> -#define MAX_RADIOS 3
> +#define MAX_RADIOS 2
>
> #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
> #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
next prev parent reply other threads:[~2024-05-13 23:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 1:36 [PATCH 0/2] wifi: ath12k: Refactor MAX_RADIOS definition Karthikeyan Periyasamy
2024-05-11 1:36 ` [PATCH 1/2] wifi: ath12k: remove duplicate definition of MAX_RADIOS Karthikeyan Periyasamy
2024-05-13 23:28 ` Jeff Johnson
2024-05-11 1:36 ` [PATCH 2/2] wifi: ath12k: use correct MAX_RADIOS Karthikeyan Periyasamy
2024-05-13 23:31 ` Jeff Johnson [this message]
2024-05-14 1:07 ` Karthikeyan Periyasamy
2024-05-14 5:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7916534b-ee14-4b95-b339-d614ce9393f1@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).