From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Xin Deng <quic_deng@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: cfg80211: Clear mlo_links info when STA disconnect
Date: Mon, 8 Apr 2024 12:42:33 -0700 [thread overview]
Message-ID: <4987737e-df85-452c-85a6-9032fb620dd5@quicinc.com> (raw)
In-Reply-To: <e599d1b1c7c6e32856eb5374cfaa20965b49b44c.camel@sipsolutions.net>
On 4/8/2024 11:41 AM, Johannes Berg wrote:
> On Tue, 2024-03-26 at 20:24 -0700, Xin Deng wrote:
>> wdev->valid_links is not cleared when upper layer disconnect from a
>> wdev->AP MLD. It has been observed that this would prevent offchannel
>> operations like remain-on-channel which would be needed for user space
>> operations with Public Action frame.
>
> I agree that's a problem, we shouldn't leave the valid_links set.
>
>> Signed-off-by: Xin Deng <quic_deng@quicinc.com>
>> ---
>> net/wireless/sme.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/wireless/sme.c b/net/wireless/sme.c
>> index 82e3ce42206c..86e837f37f8c 100644
>> --- a/net/wireless/sme.c
>> +++ b/net/wireless/sme.c
>> @@ -492,6 +492,7 @@ void cfg80211_wdev_release_link_bsses(struct wireless_dev *wdev, u16 link_mask)
>> &wdev->links[link].client.current_bss->pub);
>> wdev->links[link].client.current_bss = NULL;
>> }
>> + wdev->valid_links = 0;
>>
>
> But this is (very obviously, even with only the limited context shown!)
> in the completely wrong place.
Concur, so NAK my Reviewed-by:
That function is potentially only removing a subset of links, so it should not
be setting the valid_links to 0 since not all of the links may have been removed.
/jeff
prev parent reply other threads:[~2024-04-08 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 3:24 [PATCH] wifi: cfg80211: Clear mlo_links info when STA disconnect Xin Deng
2024-03-27 15:51 ` Jeff Johnson
2024-04-08 18:41 ` Johannes Berg
2024-04-08 19:42 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4987737e-df85-452c-85a6-9032fb620dd5@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_deng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).