From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Miaoqing Pan <quic_miaoqing@quicinc.com>, <kvalo@kernel.org>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: fix memory leak in ath12k_pci_remove()
Date: Thu, 14 Mar 2024 08:08:57 -0700 [thread overview]
Message-ID: <2f94602e-5e77-4e79-b6f1-5612133a31ba@quicinc.com> (raw)
In-Reply-To: <20240314012746.2729101-1-quic_miaoqing@quicinc.com>
On 3/13/2024 6:27 PM, Miaoqing Pan wrote:
> Kmemleak reported this error:
>
> unreferenced object 0xffff1c165cec3060 (size 32):
> comm "insmod", pid 560, jiffies 4296964570 (age 235.596s)
> backtrace:
> [<000000005434db68>] __kmem_cache_alloc_node+0x1f4/0x2c0
> [<000000001203b155>] kmalloc_trace+0x40/0x88
> [<0000000028adc9c8>] _request_firmware+0xb8/0x608
> [<00000000cad1aef7>] firmware_request_nowarn+0x50/0x80
> [<000000005011a682>] local_pci_probe+0x48/0xd0
> [<00000000077cd295>] pci_device_probe+0xb4/0x200
> [<0000000087184c94>] really_probe+0x150/0x2c0
>
> The firmware memory was allocated in ath12k_pci_probe(), but not
> freed in ath12k_pci_remove() in case ATH12K_FLAG_QMI_FAIL bit is
> set. So call ath12k_fw_unmap() to free the memory.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.2.0-02280-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1
>
> Signed-off-by: Miaoqing Pan <quic_miaoqing@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
prev parent reply other threads:[~2024-03-14 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 1:27 [PATCH] wifi: ath12k: fix memory leak in ath12k_pci_remove() Miaoqing Pan
2024-03-14 15:08 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f94602e-5e77-4e79-b6f1-5612133a31ba@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_miaoqing@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).