From: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
To: <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>,
Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Subject: [PATCH v2 2/2] wifi: ath12k: use correct MAX_RADIOS
Date: Tue, 14 May 2024 12:04:12 +0530 [thread overview]
Message-ID: <20240514063412.3483723-3-quic_periyasa@quicinc.com> (raw)
In-Reply-To: <20240514063412.3483723-1-quic_periyasa@quicinc.com>
The current value of the MAX_RADIOS definition is 3. This is incorrect
because no device supports more than 2 radios.
An incorrect MAX_RADIOS value can lead to:
- unnecessary memory allocation for pdev related entities.
- invalid pdev id validation.
- Misconceptions for code readers.
Therefore, modify the MAX_RADIOS definition as 2.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
---
drivers/net/wireless/ath/ath12k/wmi.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h
index 496866673aea..27bec3800bff 100644
--- a/drivers/net/wireless/ath/ath12k/wmi.h
+++ b/drivers/net/wireless/ath/ath12k/wmi.h
@@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd {
__le32 buf_len;
} __packed;
-#define MAX_RADIOS 3
+#define MAX_RADIOS 2
#define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ)
#define WMI_SEND_TIMEOUT_HZ (3 * HZ)
--
2.34.1
next prev parent reply other threads:[~2024-05-14 6:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 6:34 [PATCH v2 0/2] wifi: ath12k: Refactor MAX_RADIOS definition Karthikeyan Periyasamy
2024-05-14 6:34 ` [PATCH v2 1/2] wifi: ath12k: remove duplicate definition of MAX_RADIOS Karthikeyan Periyasamy
2024-05-16 8:29 ` Kalle Valo
2024-05-14 6:34 ` Karthikeyan Periyasamy [this message]
2024-05-14 14:14 ` [PATCH v2 2/2] wifi: ath12k: use correct MAX_RADIOS Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514063412.3483723-3-quic_periyasa@quicinc.com \
--to=quic_periyasa@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).