ath12k.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Baochen Qiang <quic_bqiang@quicinc.com>
To: <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <quic_bqiang@quicinc.com>
Subject: [PATCH 01/10] wifi: ath12k: rearrange IRQ enable/disable in reset path
Date: Fri, 12 Apr 2024 14:06:11 +0800	[thread overview]
Message-ID: <20240412060620.27519-2-quic_bqiang@quicinc.com> (raw)
In-Reply-To: <20240412060620.27519-1-quic_bqiang@quicinc.com>

For non-WoW suspend/resume, ath12k host powers down whole hardware
when suspend and powers up it when resume, the code path it goes
through is very like the ath12k reset logic.

In order to reuse that logic, rearrange IRQ handling in the reset
path.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1

Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
---
 drivers/net/wireless/ath/ath12k/core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/core.c b/drivers/net/wireless/ath/ath12k/core.c
index 3c522a4b3e9b..28663cf4db30 100644
--- a/drivers/net/wireless/ath/ath12k/core.c
+++ b/drivers/net/wireless/ath/ath12k/core.c
@@ -879,9 +879,8 @@ static int ath12k_core_reconfigure_on_crash(struct ath12k_base *ab)
 	int ret;
 
 	mutex_lock(&ab->core_lock);
-	ath12k_hif_irq_disable(ab);
 	ath12k_dp_pdev_free(ab);
-	ath12k_hif_stop(ab);
+	ath12k_ce_cleanup_pipes(ab);
 	ath12k_wmi_detach(ab);
 	ath12k_dp_rx_pdev_reo_cleanup(ab);
 	mutex_unlock(&ab->core_lock);
@@ -1136,6 +1135,9 @@ static void ath12k_core_reset(struct work_struct *work)
 	time_left = wait_for_completion_timeout(&ab->recovery_start,
 						ATH12K_RECOVER_START_TIMEOUT_HZ);
 
+	ath12k_hif_irq_disable(ab);
+	ath12k_hif_ce_irq_disable(ab);
+
 	ath12k_hif_power_down(ab);
 	ath12k_qmi_free_resource(ab);
 	ath12k_hif_power_up(ab);
-- 
2.25.1



  reply	other threads:[~2024-04-12  6:06 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12  6:06 [PATCH 00/10] wifi: ath12k: support suspend/resume Baochen Qiang
2024-04-12  6:06 ` Baochen Qiang [this message]
2024-04-12 18:24   ` [PATCH 01/10] wifi: ath12k: rearrange IRQ enable/disable in reset path Sidhanta Sahu
2024-04-15  5:38     ` Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-23  9:27   ` Kalle Valo
2024-04-12  6:06 ` [PATCH 02/10] wifi: ath12k: remove MHI LOOPBACK channels Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 03/10] wifi: ath12k: do not dump SRNG statistics during resume Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 04/10] wifi: ath12k: fix warning on DMA ring capabilities event Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 05/10] wifi: ath12k: decrease MHI channel buffer length to 8KB Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 06/10] wifi: ath12k: flush all packets before suspend Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 07/10] wifi: ath12k: no need to handle pktlog during suspend/resume Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 08/10] wifi: ath12k: avoid stopping mac80211 queues in ath12k_core_restart() Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 09/10] wifi: ath12k: support suspend/resume Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 10/10] wifi: ath12k: change supports_suspend to true for WCN7850 Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12 18:05 ` [PATCH 00/10] wifi: ath12k: support suspend/resume Jeff Johnson
2024-04-15  5:51   ` Baochen Qiang
2024-04-16  8:28     ` Kalle Valo
2024-04-16 10:31       ` Baochen Qiang
2024-04-17 14:22   ` Kalle Valo
2024-04-17 23:32     ` Jeff Johnson
2024-04-18  6:06       ` Jeff Johnson
2024-04-18 10:43         ` Baochen Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240412060620.27519-2-quic_bqiang@quicinc.com \
    --to=quic_bqiang@quicinc.com \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).