From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] wifi: ath12k: Remove unnecessary struct qmi_txn initializers
Date: Thu, 11 Jan 2024 16:21:19 +0000 (UTC) [thread overview]
Message-ID: <170499007813.916301.2323327164409855961.kvalo@kernel.org> (raw)
In-Reply-To: <20240109-qmi-cleanup-v1-1-607b10858566@quicinc.com>
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> Currently most of the ath12k QMI messaging functions define their
> struct qmi_txn variables with a {} initializer. However, all of these
> functions subsequently call qmi_txn_init(), and the very first thing
> that function does is zero the struct. Hence, the initializers are
> unnecessary. Since these consume code space and cpu cycles, remove
> them.
>
> No functional changes, compile tested only.
s-o-b missing on all 3 patches.
3 patches set to Changes Requested.
13515170 [1/3] wifi: ath12k: Remove unnecessary struct qmi_txn initializers
13515167 [2/3] wifi: ath12k: Add missing qmi_txn_cancel() calls
13515168 [3/3] wifi: ath12k: Use initializers for QMI message buffers
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240109-qmi-cleanup-v1-1-607b10858566@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-01-11 16:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 17:51 [PATCH 0/3] wifi: ath12k: Cleanup QMI messaging functions Jeff Johnson
2024-01-09 17:51 ` [PATCH 1/3] wifi: ath12k: Remove unnecessary struct qmi_txn initializers Jeff Johnson
2024-01-11 16:21 ` Kalle Valo [this message]
2024-01-09 17:51 ` [PATCH 2/3] wifi: ath12k: Add missing qmi_txn_cancel() calls Jeff Johnson
2024-01-09 17:51 ` [PATCH 3/3] wifi: ath12k: Use initializers for QMI message buffers Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170499007813.916301.2323327164409855961.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).