From: Kalle Valo <kvalo@kernel.org>
To: Kang Yang <quic_kangyang@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<quic_kangyang@quicinc.com>
Subject: Re: [PATCH v2 1/7] wifi: ath12k: get msi_data again after request_irq is called
Date: Tue, 5 Dec 2023 15:05:59 +0000 (UTC) [thread overview]
Message-ID: <170178875768.2413512.746840226279919618.kvalo@kernel.org> (raw)
In-Reply-To: <20231121021304.12966-2-quic_kangyang@quicinc.com>
Kang Yang <quic_kangyang@quicinc.com> wrote:
> The reservation mode of interrupts in kernel assigns a dummy vector
> when the interrupt is allocated and assigns a real vector when the
> request_irq is called. The reservation mode helps to ease vector
> pressure when devices with a large amount of queues/interrupts are
> initialized, but only a minimal subset of those queues/interrupts
> is actually used.
>
> So on reservation mode, the msi_data may change after request_irq is
> called, then it will lead to spurious interrupt. But when VT-d in
> BIOS is enabled and ath12k can get 32 MSI vectors, ath12k always get
> the same msi_data before and after request_irq.
>
> So in case of one MSI vector, ath12k need read msi_data again after
> request_irq is called, and then the correct msi_data is programmed
> into WCN7850 hardware components.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
7 patches applied to ath-next branch of ath.git, thanks.
1b66601d1416 wifi: ath12k: get msi_data again after request_irq is called
604308a34487 wifi: ath12k: add CE and ext IRQ flag to indicate irq_handler
1f1f7d548a00 wifi: ath12k: use ATH12K_PCI_IRQ_DP_OFFSET for DP IRQ
6711b2a80b9a wifi: ath12k: refactor multiple MSI vector implementation
8398654398c2 wifi: ath12k: add support one MSI vector
08d52ba29678 wifi: ath12k: do not restore ASPM in case of single MSI vector
a3012f206d07 wifi: ath12k: set IRQ affinity to CPU0 in case of one MSI vector
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231121021304.12966-2-quic_kangyang@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-12-05 15:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 2:12 [PATCH v2 0/7] wifi: ath12k: support one MSI Kang Yang
2023-11-21 2:12 ` [PATCH v2 1/7] wifi: ath12k: get msi_data again after request_irq is called Kang Yang
2023-11-21 16:06 ` Jeff Johnson
2023-12-05 15:05 ` Kalle Valo [this message]
2023-11-21 2:12 ` [PATCH v2 2/7] wifi: ath12k: add CE and ext IRQ flag to indicate irq_handler Kang Yang
2023-11-21 16:06 ` Jeff Johnson
2023-11-21 2:12 ` [PATCH v2 3/7] wifi: ath12k: use ATH12K_PCI_IRQ_DP_OFFSET for DP IRQ Kang Yang
2023-11-21 16:07 ` Jeff Johnson
2023-11-21 2:13 ` [PATCH v2 4/7] wifi: ath12k: refactor multiple MSI vector implementation Kang Yang
2023-11-21 16:07 ` Jeff Johnson
2023-11-21 2:13 ` [PATCH v2 5/7] wifi: ath12k: add support one MSI vector Kang Yang
2023-11-21 16:07 ` Jeff Johnson
2023-11-21 2:13 ` [PATCH v2 6/7] wifi: ath12k: do not restore ASPM in case of single " Kang Yang
2023-11-21 16:08 ` Jeff Johnson
2023-11-21 2:13 ` [PATCH v2 7/7] wifi: ath12k: set IRQ affinity to CPU0 in case of one " Kang Yang
2023-11-21 16:08 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170178875768.2413512.746840226279919618.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kangyang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).