From: Benjamin Berg <benjamin@sipsolutions.net>
To: Kalle Valo <kvalo@kernel.org>
Cc: linux-wireless@vger.kernel.org, lenb@kernel.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH] wifi: ath11k: rely on mac80211 debugfs handling for vif
Date: Mon, 15 Jan 2024 11:36:11 +0100 [thread overview]
Message-ID: <ef5ea65e80aa0eb8d73d37505a26d2dbc32c2e0f.camel@sipsolutions.net> (raw)
In-Reply-To: <87a5pb9cxp.fsf@kernel.org>
On Fri, 2024-01-12 at 10:24 +0200, Kalle Valo wrote:
> Kalle Valo <kvalo@kernel.org> writes:
>
> > benjamin@sipsolutions.net writes:
> >
> > > From: Benjamin Berg <benjamin.berg@intel.com>
> > >
> > > mac80211 started to delete debugfs entries in certain cases,
> > > causing a
> > > conflict between ath11k also trying to delete them later on. Fix
> > > this by
> > > relying on mac80211 to delete the entries when appropriate and
> > > adding
> > > them from the vif_add_debugfs handler.
> > >
> > > Fixes: 0a3d898ee9a8 ("wifi: mac80211: add/remove driver debugfs
> > > entries as appropriate")
> > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218364
> > > Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
> >
> > Adding ath11k list so that the whole team sees this.
>
> Thanks, this patch passes my ath11k tests and I don't see crashes
> anymore. But what about other drivers, can we trust that they don't
> have
> similar problems? I'm just wondering should we consider reverting the
> mac80211 commit for the time being?
Good question.
I did have a look originally and I just went over all drivers (i.e.
debugfs_remove calls). None of these seem to be vif related. As such, I
would say we could just go ahead with this patch and leave in the fix.
That said, we could also revert 0a3d898ee9a8 for now. I don't think
that has any severe side effects other than a warning from debugfs
reappearing again for iwlwifi.
Benjamin
next prev parent reply other threads:[~2024-01-15 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240111170629.1257217-1-benjamin@sipsolutions.net>
2024-01-11 20:38 ` [PATCH] wifi: ath11k: rely on mac80211 debugfs handling for vif Kalle Valo
2024-01-12 8:24 ` Kalle Valo
2024-01-15 10:36 ` Benjamin Berg [this message]
2024-01-14 15:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef5ea65e80aa0eb8d73d37505a26d2dbc32c2e0f.camel@sipsolutions.net \
--to=benjamin@sipsolutions.net \
--cc=ath11k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).