From: Jakub Kicinski <kuba@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: Breno Leitao <leitao@debian.org>,
horms@kernel.org, Jeff Johnson <jjohnson@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org,
linux-wireless@vger.kernel.org (open list:NETWORKING DRIVERS
(WIRELESS)),
ath11k@lists.infradead.org (open list:QUALCOMM ATHEROS ATH11K
WIRELESS DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config
Date: Tue, 14 May 2024 06:51:53 -0700 [thread overview]
Message-ID: <20240514065153.1320f47f@kernel.org> (raw)
In-Reply-To: <171569306687.2017278.16792087877494747045.kvalo@kernel.org>
On Tue, 14 May 2024 13:24:28 +0000 (UTC) Kalle Valo wrote:
> > If one of the dummy allocation fails in ath11k_pcic_ext_irq_config(),
> > the previous allocated devices might leak due to returning without
> > deallocating the devices.
> >
> > Instead of returning on the error path, deallocate all the previously
> > allocated net_devices and then return.
> >
> > Fixes: bca592ead825 ("wifi: ath11k: allocate dummy net_device dynamically")
> > Signed-off-by: Breno Leitao <leitao@debian.org>
> > Reviewed-by: Simon Horman <horms@kernel.org>
>
> As commit bca592ead825 is in net-next I think this patch needs to go to v6.10, right?
There's no rush, FWIW, we can pick up the conversion after the merge
window.
next prev parent reply other threads:[~2024-05-14 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 18:59 [PATCH wireless-next] ath11k: Fix error path in ath11k_pcic_ext_irq_config Breno Leitao
2024-05-10 11:56 ` Simon Horman
2024-05-14 13:24 ` Kalle Valo
2024-05-14 13:51 ` Jakub Kicinski [this message]
2024-05-17 6:55 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240514065153.1320f47f@kernel.org \
--to=kuba@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).