From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Jeff Johnson <jjohnson@kernel.org>,
<linux-wireless@vger.kernel.org>, <ath12k@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <ath11k@lists.infradead.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH 1/2] wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem()
Date: Mon, 13 May 2024 14:12:32 +0000 (UTC) [thread overview]
Message-ID: <171560955084.1690511.16227061715514007364.kvalo@kernel.org> (raw)
In-Reply-To: <20240504-qmi_load_file_target_mem-v1-1-069fc44c45eb@quicinc.com>
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> smatch flagged the following issue:
>
> drivers/net/wireless/ath/ath12k/qmi.c:2619 ath12k_qmi_load_file_target_mem() error: uninitialized symbol 'ret'.
>
> The reality is that 'ret' is initialized in every path through
> ath12k_qmi_load_file_target_mem() except one, the case where the input
> 'len' is 0, and hence the "while (remaining)" loop is never entered.
> But to make sure this case is also handled, add an initializer to the
> declaration of 'ret'.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
2 patches applied to ath-next branch of ath.git, thanks.
bb0b0a6b96e6 wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem()
199f149e97dc wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240504-qmi_load_file_target_mem-v1-1-069fc44c45eb@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-05-13 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 18:52 [PATCH 0/2] wifi: ath1*k: initialize 'ret' in ath1*k_qmi_load_file_target_mem() Jeff Johnson
2024-05-04 18:52 ` [PATCH 1/2] wifi: ath12k: initialize 'ret' in ath12k_qmi_load_file_target_mem() Jeff Johnson
2024-05-13 14:12 ` Kalle Valo [this message]
2024-05-04 18:52 ` [PATCH 2/2] wifi: ath11k: initialize 'ret' in ath11k_qmi_load_file_target_mem() Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171560955084.1690511.16227061715514007364.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).