From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] wifi: ath11k: fix soc_dp_stats debugfs file permission
Date: Fri, 8 Mar 2024 15:06:07 +0000 (UTC) [thread overview]
Message-ID: <170991036603.1311983.8197697439450200231.kvalo@kernel.org> (raw)
In-Reply-To: <20240305-fix-soc_dp_stats-permission-v1-1-2ec10b42f755@quicinc.com>
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> Currently the soc_dp_stats debugfs file has the following permissions:
>
> # ls -l /sys/kernel/debug/ath11k/pci-0000:03:00.0/soc_dp_stats
> -rw------- 1 root root 0 Mar 4 15:04 /sys/kernel/debug/ath11k/pci-0000:03:00.0/soc_dp_stats
>
> However this file does not actually support write operations -- no .write()
> method is registered. Therefore use the correct permissions when creating
> the file.
>
> After the change:
>
> # ls -l /sys/kernel/debug/ath11k/pci-0000:03:00.0/soc_dp_stats
> -r-------- 1 root root 0 Mar 4 15:15 /sys/kernel/debug/ath11k/pci-0000:03:00.0/soc_dp_stats
>
> Tested-on: WCN6855 hw2.1 PCI WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
fa645e663165 wifi: ath11k: fix soc_dp_stats debugfs file permission
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240305-fix-soc_dp_stats-permission-v1-1-2ec10b42f755@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-03-08 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 15:14 [PATCH] wifi: ath11k: fix soc_dp_stats debugfs file permission Jeff Johnson
2024-03-08 15:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170991036603.1311983.8197697439450200231.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).