From: Kalle Valo <kvalo@kernel.org>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Li Zhijian <lizhijian@fujitsu.com>,
Jeff Johnson <jjohnson@kernel.org>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit
Date: Mon, 25 Mar 2024 10:49:56 +0000 (UTC) [thread overview]
Message-ID: <171136379518.1022746.15442509873111996623.kvalo@kernel.org> (raw)
In-Reply-To: <20240315055211.1347548-1-lizhijian@fujitsu.com>
Li Zhijian <lizhijian@fujitsu.com> wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Kalle Valo <kvalo@kernel.org>
> CC: Jeff Johnson <jjohnson@kernel.org>
> CC: linux-wireless@vger.kernel.org
> CC: ath11k@lists.infradead.org
> CC: ath10k@lists.infradead.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
fa1a4f15bdca wifi: ath: Convert sprintf/snprintf to sysfs_emit
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-1-lizhijian@fujitsu.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-03-25 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 5:52 [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit Li Zhijian
2024-03-25 10:49 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171136379518.1022746.15442509873111996623.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=ath11k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lizhijian@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).