From: Hector Martin <marcan@marcan.st>
To: fnkl.kernel@gmail.com, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: apple: t8112: Add PWM controller
Date: Mon, 17 Apr 2023 18:20:11 +0900 [thread overview]
Message-ID: <c366d449-542f-8365-9f04-74da4ef847be@marcan.st> (raw)
In-Reply-To: <20230409-t8112-fpwm-v1-1-feffa5f8b99b@gmail.com>
On 09/04/2023 18.18, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <fnkl.kernel@gmail.com>
>
> This patch adds the device tree entries for the PWM controller
> present on M2 macbooks that is connected to the keyboard backlight.
>
> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
> ---
> arch/arm64/boot/dts/apple/t8112-j413.dts | 17 +++++++++++++++++
> arch/arm64/boot/dts/apple/t8112-j493.dts | 17 +++++++++++++++++
> arch/arm64/boot/dts/apple/t8112.dtsi | 9 +++++++++
> 3 files changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts b/arch/arm64/boot/dts/apple/t8112-j413.dts
> index 9e758edeaa82..6f69658623bf 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j413.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts
> @@ -11,6 +11,7 @@
>
> #include "t8112.dtsi"
> #include "t8112-jxxx.dtsi"
> +#include <dt-bindings/leds/common.h>
>
> / {
> compatible = "apple,j413", "apple,t8112", "apple,arm-platform";
> @@ -20,6 +21,18 @@ aliases {
> bluetooth0 = &bluetooth0;
> wifi0 = &wifi0;
> };
> +
> + led-controller {
> + compatible = "pwm-leds";
> + led-0 {
> + pwms = <&fpwm1 0 40000>;
> + label = "kbd_backlight";
> + function = LED_FUNCTION_KBD_BACKLIGHT;
> + color = <LED_COLOR_ID_WHITE>;
> + max-brightness = <255>;
> + default-state = "keep";
> + };
> + };
> };
>
> /*
> @@ -61,3 +74,7 @@ hpm5: usb-pd@3a {
> &i2c4 {
> status = "okay";
> };
> +
> +&fpwm1 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts
> index 8552c15be265..0ad908349f55 100644
> --- a/arch/arm64/boot/dts/apple/t8112-j493.dts
> +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts
> @@ -11,6 +11,7 @@
>
> #include "t8112.dtsi"
> #include "t8112-jxxx.dtsi"
> +#include <dt-bindings/leds/common.h>
>
> / {
> compatible = "apple,j493", "apple,t8112", "apple,arm-platform";
> @@ -20,6 +21,18 @@ aliases {
> bluetooth0 = &bluetooth0;
> wifi0 = &wifi0;
> };
> +
> + led-controller {
> + compatible = "pwm-leds";
> + led-0 {
> + pwms = <&fpwm1 0 40000>;
> + label = "kbd_backlight";
> + function = LED_FUNCTION_KBD_BACKLIGHT;
> + color = <LED_COLOR_ID_WHITE>;
> + max-brightness = <255>;
> + default-state = "keep";
> + };
> + };
> };
>
> /*
> @@ -50,3 +63,7 @@ bluetooth0: bluetooth@0,1 {
> &i2c4 {
> status = "okay";
> };
> +
> +&fpwm1 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index 698a436e7dac..1666e6ab250b 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
> @@ -458,6 +458,15 @@ i2c4: i2c@235020000 {
> status = "disabled";
> };
>
> + fpwm1: pwm@235044000 {
> + compatible = "apple,t8112-fpwm", "apple,s5l-fpwm";
> + reg = <0x2 0x35044000 0x0 0x4000>;
> + power-domains = <&ps_fpwm1>;
> + clocks = <&clkref>;
> + #pwm-cells = <2>;
> + status = "disabled";
> + };
> +
> serial0: serial@235200000 {
> compatible = "apple,s5l-uart";
> reg = <0x2 0x35200000 0x0 0x1000>;
>
> ---
> base-commit: 8d59efc33fdaa2c82072b4d3ba5f67d7dd9270d0
> change-id: 20230409-t8112-fpwm-06e434cc358d
Applied to asahi-soc/dt, thanks!
- Hector
prev parent reply other threads:[~2023-04-17 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 9:18 [PATCH] arm64: dts: apple: t8112: Add PWM controller Sasha Finkelstein via B4 Relay
2023-04-17 9:20 ` Hector Martin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c366d449-542f-8365-9f04-74da4ef847be@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).