From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Janne Grunau <j@jannau.net>
Cc: linux-bluetooth@vger.kernel.org, regressions@lists.linux.dev,
asahi@lists.linux.dev
Subject: Re: [PATCH v1] Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync
Date: Thu, 9 May 2024 18:41:06 -0400 [thread overview]
Message-ID: <CABBYNZJ-6oyLnBov9H_jym9m-9qiUt1ELxYGuBOdZT29aj9MCA@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZLnYz-vPrMbtsJTsLPsyo62j+cxctSkLjRom3bWEU9N3A@mail.gmail.com>
Hi Janne,
On Thu, May 9, 2024 at 6:23 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Janne,
>
> On Thu, May 9, 2024 at 4:09 PM Janne Grunau <j@jannau.net> wrote:
> >
> > On Thu, May 09, 2024 at 12:30:21PM -0400, Luiz Augusto von Dentz wrote:
> > > Hi Janne,
> > >
> > > On Thu, May 9, 2024 at 12:06 PM Janne Grunau <j@jannau.net> wrote:
> > > >
> > > > Hej,
> > > >
> > > > On Fri, Apr 05, 2024 at 04:40:33PM -0400, Luiz Augusto von Dentz wrote:
> > > > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > > > >
> > > > > The extended advertising reports do report the PHYs so this store then
> > > > > in hci_conn so it can be later used in hci_le_ext_create_conn_sync to
> > > > > narrow the PHYs to be scanned since the controller will also perform a
> > > > > scan having a smaller set of PHYs shall reduce the time it takes to
> > > > > find and connect peers.
> > > > >
> > > > > Fixes: 288c90224eec ("Bluetooth: Enable all supported LE PHY by default")
> > > >
> > > > This commit in v6.8.9 apparently has regressed connecting to LE devices
> > > > like Logitech mices with Apple/Broadcom BCM4388 devices. Those devices
> > > > carry HCI_QUIRK_BROKEN_LE_CODED which became necessary after 288c90224eec
> > > > ("Bluetooth: Enable all supported LE PHY by default").
> > > > Tested so far only by reverting aaf06285498861d6caaff5b26d30af70dd2b819f
> > > > on top of v6.8.9. Looking at the change I don't see anything obvious
> > > > which would explain the breakage.
> > > > I would assume v6.9-rc6 is affected as well but I haven't tested this
> > > > yet.
> > >
> > > Would be great if you provide the HCI trace to confirm the problem.
> >
> > looks like there is an issue with initiating "LE Extended Create
> > Connection":
> >
> > | > HCI Event: LE Meta Event (0x3e) plen 26
> > | LE Extended Advertising Report (0x0d)
> > | Num reports: 1
> > | Entry 0
> > | Event type: 0x2515
> > | Props: 0x0015
> > | Connectable
> > | Directed
> > | Use legacy advertising PDUs
> > | Data status: Complete
> > | Reserved (0x2500)
> > | Legacy PDU Type: Reserved (0x2515)
> > | Address type: Random (0x01)
> > | Address: DF:F4:9E:F3:A9:72 (Static)
> > | Primary PHY: Reserved
>
> Looks like broadcom is using Reserved value as primary PHY, no wonder
> it doesn't work, real piece of art that broadcom and apple manage to
> produce and it is not only the PHY that has out of the spec result
> other fields are affected as well.
If I print the actual value then we got:
Primary PHY: Reserved (0x81)
I guess one needs to disregard the reserved range, well until they are
no longer reserved then it will no longer work. Perhaps we should talk
to broadcom to know what is up with using reserved values and if that
is an apple thing then perhaps we could ask them to provide firmware
that acts according to the spec.
> > | Secondary PHY: No packets
> > | SID: no ADI field (0xff)
> > | TX power: 127 dBm
> > | RSSI: -60 dBm (0xc4)
> > | Periodic advertising interval: 0.00 msec (0x0000)
> > | Direct address type: Public (0x00)
> > | Direct address: 5C:1B:F4:7F:BF:6B (Apple, Inc.)
> > | Data length: 0x00
> > | < HCI Command: LE Set Extended Scan Enable (0x08|0x0042) plen 6
> > | Extended scan: Disabled (0x00)
> > | Filter duplicates: Disabled (0x00)
> > | Duration: 0 msec (0x0000)
> > | Period: 0.00 sec (0x0000)
> > | > HCI Event: Command Complete (0x0e) plen 4
> > | LE Set Extended Scan Enable (0x08|0x0042) ncmd 1
> > | Status: Success (0x00)
> > | < HCI Command: LE Extended Create Connection (0x08|0x0043) plen 10
> > | Filter policy: Accept list is not used (0x00)
> > | Own address type: Public (0x00)
> > | Peer address type: Random (0x01)
> > | Peer address: DF:F4:9E:F3:A9:72 (Static)
> > | Initiating PHYs: 0x00
> > | > HCI Event: Command Status (0x0f) plen 4
> > | LE Extended Create Connection (0x08|0x0043) ncmd 1
> > | Status: Unsupported Feature or Parameter Value (0x11)
> >
> > Full trace attached
> >
> > Janne
>
>
>
> --
> Luiz Augusto von Dentz
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2024-05-09 22:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240405204037.3451091-1-luiz.dentz@gmail.com>
2024-05-09 16:06 ` [PATCH v1] Bluetooth: hci_sync: Use advertised PHYs on hci_le_ext_create_conn_sync Janne Grunau
2024-05-09 16:30 ` Luiz Augusto von Dentz
2024-05-09 20:09 ` Janne Grunau
2024-05-09 22:23 ` Luiz Augusto von Dentz
2024-05-09 22:41 ` Luiz Augusto von Dentz [this message]
2024-05-10 3:13 ` Hector Martin
2024-05-10 9:54 ` Sven Peter
2024-05-10 14:33 ` Luiz Augusto von Dentz
2024-05-10 14:43 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABBYNZJ-6oyLnBov9H_jym9m-9qiUt1ELxYGuBOdZT29aj9MCA@mail.gmail.com \
--to=luiz.dentz@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).