From: "Martin Povišer" <povik+lin@cutebit.org>
To: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Vinod Koul <vkoul@kernel.org>
Cc: Alyssa Rosenzweig <alyssa@rosenzweig.io>,
asahi@lists.linux.dev,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
dmaengine@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: apple-admac: Keep upper bits of REG_BUS_WIDTH
Date: Sun, 29 Oct 2023 18:10:41 +0100 [thread overview]
Message-ID: <00401D09-6037-44AE-91CC-34379ED9589E@cutebit.org> (raw)
In-Reply-To: <20231029170053.82146-1-povik+lin@cutebit.org>
> On 29. 10. 2023, at 18:00, Martin Povišer <povik+lin@cutebit.org> wrote:
>
> From: Hector Martin <marcan@marcan.st>
>
> For RX channels, REG_BUS_WIDTH seems to default to a value of 0xf00, and
> macOS preserves the upper bits when setting the configuration in the
> lower ones. If we reset the upper bits to 0, this causes framing errors
> on suspend/resume (the data stream "tears" and channels get swapped
> around). Keeping the upper bits untouched, like the macOS driver does,
> fixes this issue.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Reviewed-by: Martin Povišer <povik@cutebit.org>
> Signed-off-by: Martin Povišer <povik@cutebit.org>
> ---
Please take up v2 instead. I slipped in the wrong email address in here,
which I don’t want to subscribe for kernel spam with.
https://lore.kernel.org/dmaengine/20231029170704.82238-1-povik+lin@cutebit.org/T/#u
Thanks!
Kind regards,
Martin
prev parent reply other threads:[~2023-10-29 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 17:00 [PATCH] dmaengine: apple-admac: Keep upper bits of REG_BUS_WIDTH Martin Povišer
2023-10-29 17:10 ` Martin Povišer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00401D09-6037-44AE-91CC-34379ED9589E@cutebit.org \
--to=povik+lin@cutebit.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=sven@svenpeter.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).