From: Alex Deucher <alexdeucher@gmail.com>
To: Kendall Smith <kendallsm2@icloud.com>
Cc: amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/radeon: initialize atom DIG backlight for iMac12, 1 and iMac12, 2 with Radeon 6750M
Date: Thu, 16 May 2024 10:18:24 -0400 [thread overview]
Message-ID: <CADnq5_Mb1fDJ=Z8Knnyj5B1YRN+ni1_mmje+==-C9ytmX0Z1uQ@mail.gmail.com> (raw)
In-Reply-To: <20240515192009.14362-1-kendallsm2@icloud.com>
Applied. Thanks!
Alex
On Wed, May 15, 2024 at 5:47 PM Kendall Smith <kendallsm2@icloud.com> wrote:
>
> If a Radeon 6750M GPU from an iMac12,1 is installed into an iMac 12,2, there is no backlight device initialized during boot. Everything else is functional, but the display brightness cannot be controlled. There are no directories present in /sys/class/backlight after booting. A simple one line modification to an if statement fixes this issue by initializing the radeon backlight device for an iMac12,2 as well if it has a 6750M. After the patch, brightness can be controlled and radeon_bl0 is present in /sys/class/backlight. This was tested by compiling the latest kernel with and without the patch.
>
> Signed-off-by: Kendall Smith <kendallsm2@icloud.com>
> ---
> drivers/gpu/drm/radeon/atombios_encoders.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c
> index 2bff0d9e20f5..7b11674f5d45 100644
> --- a/drivers/gpu/drm/radeon/atombios_encoders.c
> +++ b/drivers/gpu/drm/radeon/atombios_encoders.c
> @@ -201,7 +201,7 @@ void radeon_atom_backlight_init(struct radeon_encoder *radeon_encoder,
> */
> if ((rdev->pdev->subsystem_vendor == PCI_VENDOR_ID_APPLE) &&
> (rdev->pdev->device == 0x6741) &&
> - !dmi_match(DMI_PRODUCT_NAME, "iMac12,1"))
> + !(dmi_match(DMI_PRODUCT_NAME, "iMac12,1") || dmi_match(DMI_PRODUCT_NAME, "iMac12,2")))
> return;
>
> if (!radeon_encoder->enc_priv)
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-05-16 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 19:20 [PATCH] drm/radeon: initialize atom DIG backlight for iMac12, 1 and iMac12, 2 with Radeon 6750M Kendall Smith
2024-05-16 14:18 ` Alex Deucher [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-15 19:42 Kendall Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_Mb1fDJ=Z8Knnyj5B1YRN+ni1_mmje+==-C9ytmX0Z1uQ@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=kendallsm2@icloud.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).