From: "Chung, ChiaHsuan (Tom)" <chiahsuan.chung@amd.com>
To: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Aurabindo Pillai <aurabindo.pillai@amd.com>
Cc: amd-gfx@lists.freedesktop.org, Roman Li <roman.li@amd.com>
Subject: Re: [PATCH] drm/amdgpu/display: Update kdoc for 'optc35_set_odm_combine'
Date: Thu, 16 May 2024 15:34:14 +0800 [thread overview]
Message-ID: <2b14d07d-d589-4b38-8fc7-ae2d5c7a5e9c@amd.com> (raw)
In-Reply-To: <20240515152341.750360-1-srinivasan.shanmugam@amd.com>
Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>
On 5/15/2024 11:23 PM, Srinivasan Shanmugam wrote:
> The parameters segment_width and last_segment_width are used to control
> the configuration of the Output Plane Processor (OPP), specifically the
> width of each segment that the display is divided into and the width of
> the last segment
>
> Fixes the below with gcc W=1:
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Function parameter or struct member 'segment_width' not described in 'optc35_set_odm_combine'
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Function parameter or struct member 'last_segment_width' not described in 'optc35_set_odm_combine'
> drivers/gpu/drm/amd/amdgpu/../display/dc/optc/dcn35/dcn35_optc.c:59: warning: Excess function parameter 'timing' description in 'optc35_set_odm_combine'
>
> Cc: Tom Chung <chiahsuan.chung@amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> Cc: Roman Li <roman.li@amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c b/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> index 7c9faa507ec2..dfa9364fe5a6 100644
> --- a/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
> @@ -50,7 +50,8 @@
> * @optc: Output Pipe Timing Combine instance reference.
> * @opp_id: Output Plane Processor instance ID.
> * @opp_cnt: Output Plane Processor count.
> - * @timing: Timing parameters used to configure DCN blocks.
> + * @segment_width: Width of the segment.
> + * @last_segment_width: Width of the last segment.
> *
> * Return: void.
> */
prev parent reply other threads:[~2024-05-16 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 15:23 [PATCH] drm/amdgpu/display: Update kdoc for 'optc35_set_odm_combine' Srinivasan Shanmugam
2024-05-16 7:34 ` Chung, ChiaHsuan (Tom) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b14d07d-d589-4b38-8fc7-ae2d5c7a5e9c@amd.com \
--to=chiahsuan.chung@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aurabindo.pillai@amd.com \
--cc=roman.li@amd.com \
--cc=srinivasan.shanmugam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).