From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Ma Jun <Jun.Ma2@amd.com>, amd-gfx@lists.freedesktop.org
Cc: Kenneth.Feng@amd.com, Alexander.Deucher@amd.com,
kevinyang.wang@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH] drm/amdgpu/pm: Drop hard-code value of usTMax
Date: Tue, 14 May 2024 12:26:21 +0530 [thread overview]
Message-ID: <0e35298d-fcc5-4885-992a-8e02a7de1317@amd.com> (raw)
In-Reply-To: <20240514041303.605558-1-Jun.Ma2@amd.com>
On 5/14/2024 9:43 AM, Ma Jun wrote:
> Drop hard-code value of nsTmax because we read this
> value from fantable below.
>
> Signed-off-by: Ma Jun <Jun.Ma2@amd.com>
Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Thanks,
Lijo
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> index 17882f8dfdd3..6cfef1b295ab 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/process_pptables_v1_0.c
> @@ -977,8 +977,6 @@ static int init_thermal_controller(
> = le16_to_cpu(tonga_fan_table->usPWMMed);
> hwmgr->thermal_controller.advanceFanControlParameters.usPWMHigh
> = le16_to_cpu(tonga_fan_table->usPWMHigh);
> - hwmgr->thermal_controller.advanceFanControlParameters.usTMax
> - = 10900; /* hard coded */
> hwmgr->thermal_controller.advanceFanControlParameters.usTMax
> = le16_to_cpu(tonga_fan_table->usTMax);
> hwmgr->thermal_controller.advanceFanControlParameters.ucFanControlMode
prev parent reply other threads:[~2024-05-14 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 4:13 [PATCH] drm/amdgpu/pm: Drop hard-code value of usTMax Ma Jun
2024-05-14 6:56 ` Lazar, Lijo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e35298d-fcc5-4885-992a-8e02a7de1317@amd.com \
--to=lijo.lazar@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Jun.Ma2@amd.com \
--cc=Kenneth.Feng@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=kevinyang.wang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).