From: Dan Carpenter <dan.carpenter@linaro.org>
To: Sreekant Somasekharan <sreekant.somasekharan@amd.com>
Cc: amd-gfx@lists.freedesktop.org, felix.kuehling@amd.com
Subject: Re: [PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function
Date: Wed, 15 May 2024 08:53:05 +0200 [thread overview]
Message-ID: <01da1678-91ca-498e-b317-f340ad6eb677@suswa.mountain> (raw)
In-Reply-To: <20240515003103.634408-1-sreekant.somasekharan@amd.com>
On Tue, May 14, 2024 at 08:31:03PM -0400, Sreekant Somasekharan wrote:
> Remove bo NULL check in amdgpu/gmc_v12_0.c:gmc_v12_0_get_vm_pte() function
> to fix smatch warning:
>
> 'drivers/gpu/drm/amd/amdgpu/gmc_v12_0.c:518 gmc_v12_0_get_vm_pte()
> warn: variable dereferenced before check 'bo' (see line 500)'
>
> Signed-off-by: Sreekant Somasekharan <sreekant.somasekharan@amd.com>
> Suggested-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
This is fine, but you're overthinking these... The v1 patch was also
fine.
regards,
dan carpenter
next prev parent reply other threads:[~2024-05-15 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 0:31 [PATCH v3] drm/amdkfd: Remove bo NULL check in gmc_v12_0_get_vm_pte() function Sreekant Somasekharan
2024-05-15 6:53 ` Dan Carpenter [this message]
2024-05-15 13:04 ` Russell, Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01da1678-91ca-498e-b317-f340ad6eb677@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=sreekant.somasekharan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).