From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, "Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: <alsa-devel@alsa-project.org>, <linux-arm-msm@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
<quic_pkumpatl@quicinc.com>
Subject: Re: [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw
Date: Mon, 22 Apr 2024 16:07:56 +0530 [thread overview]
Message-ID: <ced05784-79f8-2ec5-59ef-7fcbb3ac1988@quicinc.com> (raw)
In-Reply-To: <20acec19-0dc9-4926-aac5-f24fcc09cba3@kernel.org>
On 4/17/2024 9:26 PM, Krzysztof Kozlowski wrote:
> On 16/04/2024 08:35, Mohammad Rafi Shaik wrote:
>> From: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>>
>> Qualcomm WCD9370/WCD9375 Codec is a standalone Hi-Fi audio codec IC
>> connected over SoundWire. This device has two SoundWire devices RX and
>> TX respectively.
>> This binding is for those slave devices on WCD9370/WCD9375.
>>
>> Co-developed-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>> .../bindings/sound/qcom,wcd937x-sdw.yaml | 71 +++++++++++++++++++
>> 1 file changed, 71 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>> new file mode 100644
>> index 000000000000..2b7358e266ba
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd937x-sdw.yaml
>> @@ -0,0 +1,71 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/sound/qcom,wcd937x-sdw.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Qualcomm SoundWire Slave devices on WCD9370
>> +
>> +maintainers:
>> + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> +
>> +description: |
>
> Do not need '|' unless you need to preserve formatting.
ACK
will remove '|' in next version patch set.
>
>> + Qualcomm WCD9370 Codec is a standalone Hi-Fi audio codec IC.
>> + It has RX and TX Soundwire slave devices. This bindings is for the
>> + slave devices.
>> +
>> +properties:
>> + compatible:
>> + const: sdw20217010a00
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + qcom,tx-port-mapping:
>> + description: |
>> + Specifies static port mapping between slave and master tx ports.
>> + In the order of slave port index.
>
> Use inclusive terminology. Describe what is here - what is the index?
> What is the value?
ACK
>
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + minItems: 4
>> + maxItems: 4
>
> Add constraints on values. You have maximum 15 TX ports, don't you?
>
>> +
>> + qcom,rx-port-mapping:
>> + description: |
>> + Specifies static port mapping between slave and master rx ports.
>> + In the order of slave port index.
>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>> + minItems: 5
>> + maxItems: 5
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - qcom,port-mapping
>
> Test your binding. There is no need to engage reviewers for reviewing
> simple mistakes which *tools* can point. Respect reviewers time and use
> the tools first.
>
> You need oneOf: with required for TX and RX... or just unify the
> properties. Why do you need two?
>
ACK,
will fix the binding errors.
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + soundwire@3210000 {
> Drop unit address.
actually took the reference from wcd938x.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/sound/qcom,wcd938x-sdw.yaml#n48
>
>> + #address-cells = <2>;
>> + #size-cells = <0>;
>> + reg = <0x03210000 0x2000>;
>
> Drop, not relevant and not placed correctly (see DTS coding style).
>> + wcd937x_rx: codec@0,4 {
>
> Drop label, not used.
>
>> + compatible = "sdw20217010a00";
>> + reg = <0 4>;
>> + qcom,rx-port-mapping = <1 2 3 4 5>;
>> + };
>> + };
>> +
>> + soundwire@3230000 {
>
> Drop this example, it's almost identical.
>
> Best regards,
> Krzysztof
>
Thanks & Regards,
Rafi
next prev parent reply other threads:[~2024-04-22 10:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 6:35 [PATCH v2 0/8] ASoC: codecs: wcd937x: add wcd937x audio codec support Mohammad Rafi Shaik
2024-04-16 6:35 ` [PATCH v2 1/8] ASoC: dt-bindings: wcd937x: add bindings for wcd937x Mohammad Rafi Shaik
2024-04-17 15:51 ` Krzysztof Kozlowski
2024-04-22 6:55 ` Mohammad Rafi Shaik
2024-04-16 6:35 ` [PATCH v2 2/8] ASoC: codecs: wcd937x: add wcd937x codec driver Mohammad Rafi Shaik
2024-04-17 20:40 ` Konrad Dybcio
2024-04-16 6:35 ` [PATCH v2 3/8] ASoC: dt-bindings: wcd937x-sdw: add bindings for wcd937x-sdw Mohammad Rafi Shaik
2024-04-16 7:51 ` Rob Herring
2024-04-16 14:32 ` Rob Herring
2024-04-17 8:17 ` Mohammad Rafi Shaik
2024-04-17 15:52 ` Krzysztof Kozlowski
2024-04-17 15:56 ` Krzysztof Kozlowski
2024-04-22 10:37 ` Mohammad Rafi Shaik [this message]
2024-04-16 6:35 ` [PATCH v2 4/8] ASoC: codecs: wcd937x-sdw: add SoundWire driver Mohammad Rafi Shaik
2024-04-16 6:35 ` [PATCH v2 5/8] ASoC: codecs: wcd937x: add basic controls Mohammad Rafi Shaik
2024-04-16 6:35 ` [PATCH v2 6/8] ASoC: codecs: wcd937x: add playback dapm widgets Mohammad Rafi Shaik
2024-04-16 6:35 ` [PATCH v2 7/8] ASoC: codecs: wcd937x: add capture " Mohammad Rafi Shaik
2024-04-16 6:36 ` [PATCH v2 8/8] ASoC: codecs: wcd937x: add audio routing and Kconfig Mohammad Rafi Shaik
2024-04-16 12:40 ` [PATCH v2 0/8] ASoC: codecs: wcd937x: add wcd937x audio codec support Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ced05784-79f8-2ec5-59ef-7fcbb3ac1988@quicinc.com \
--to=quic_mohs@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).