From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"James Schulman" <james.schulman@cirrus.com>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
"Banajit Goswami" <bgoswami@quicinc.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping in Audioreach
Date: Tue, 7 May 2024 20:16:09 +0200 [thread overview]
Message-ID: <cd26593f-31bc-4a1d-abd9-2fbf3539b030@linaro.org> (raw)
In-Reply-To: <89cf75d8-1f85-43d8-9c33-377a04b36121@linaro.org>
On 07/05/2024 15:25, Srinivas Kandagatla wrote:
>
>
> On 07/05/2024 11:27, Krzysztof Kozlowski wrote:
>> Instead of relying on default channel mapping in all Audioreach
>> platforms, implement set_channel_map() callback to allow sound cards
>> customize the mapping depending on needs.
>>
>> The channel mapping is set on frontend DAIs coming from the topology,
>> not DTS, thus need to add DAI ops in topology dai_load() callback.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> sound/soc/qcom/qdsp6/audioreach.c | 2 +-
>> sound/soc/qcom/qdsp6/audioreach.h | 1 +
>> sound/soc/qcom/qdsp6/q6apm.c | 28 +++++++++++++++++++++++++++-
>> sound/soc/qcom/qdsp6/q6apm.h | 8 ++++++++
>> sound/soc/qcom/qdsp6/topology.c | 12 ++++++++++++
>> 5 files changed, 49 insertions(+), 2 deletions(-)
> Please use the existing q6dma_set_channel_map() and set the channel map
> for the backend dai from machine driver, this should work.
>
> setting channels on FE is not a scalable one.
>
> Please take a look at some of the patches that I shared privately.
>
Ack
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-07 18:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 10:27 [PATCH 0/4] ASoC: qcom: x1e80100: Correct channel mapping Krzysztof Kozlowski
2024-05-07 10:27 ` [PATCH 1/4] ASoC: Constify channel mapping array arguments in set_channel_map() Krzysztof Kozlowski
2024-05-07 11:57 ` Charles Keepax
2024-05-07 10:27 ` [PATCH 2/4] ASoC: qcom: q6dsp: Implement proper channel mapping in Audioreach Krzysztof Kozlowski
2024-05-07 13:25 ` Srinivas Kandagatla
2024-05-07 18:16 ` Krzysztof Kozlowski [this message]
2024-05-07 10:27 ` [PATCH 3/4] ASoC: qcom: q6dsp: Set channel mapping instead of fixed defaults Krzysztof Kozlowski
2024-05-07 10:27 ` [PATCH 4/4] ASoC: qcom: x1e80100: Correct channel mapping Krzysztof Kozlowski
2024-05-07 13:20 ` Srinivas Kandagatla
2024-05-07 18:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd26593f-31bc-4a1d-abd9-2fbf3539b030@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=james.schulman@cirrus.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).