From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Jaroslav Kysela <perex@perex.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor.dooley@microchip.com>
Cc: Walker Chen <walker.chen@starfivetech.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: Add PDM controller for the StarFive JH8100 SoC
Date: Tue, 23 Apr 2024 11:49:28 +0200 [thread overview]
Message-ID: <a5f8746f-14f8-4e56-9ac7-30c7ba6fad30@linaro.org> (raw)
In-Reply-To: <20240423083405.263912-2-xingyu.wu@starfivetech.com>
On 23/04/2024 10:34, Xingyu Wu wrote:
> Add bindings about the PDM controller for the StarFive JH8100 SoC.
>
> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com>
If there is going to be resend/new version, three nits. Anyway:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
...
> +
> +title: StarFive JH8100 PDM controller
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + The Pulse Density Modulation (PDM) controller is a digital PDM out
> + microphone interface controller and decoder that supports both up to 4
> + channels, and an Inter-IC Sound (I2S) transmitter that outputs standard
> + stereo audio data to another device. The I2S transmitter can be
> + configured to operate either a master or a slave (default mode). The PDM
> + controller includes two PDM blocks, each PDM block can drive one
> + bitstream sampling clock and two bitstream coming data (mono/stereo)
> + with sampling clock rising and falling edge.
> +
> +maintainers:
> + - Xingyu Wu <xingyu.wu@starfivetech.com>
> + - Walker Chen <walker.chen@starfivetech.com>
> +
> +allOf:
> + - $ref: dai-common.yaml#
> +
> +properties:
> + compatible:
> + const: starfive,jh8100-pdm
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: DMIC output clock
> + - description: Main ICG clock
> +
> + clock-names:
> + items:
> + - const: dmic
> + - const: icg
> +
> + resets:
> + maxItems: 1
> +
> + "#sound-dai-cells":
> + const: 0
> +
> + starfive,syscon:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to System Register Controller sys_syscon_ne node.
> + - description: PDM source enabled control offset of SYS_SYSCON_NE register.
> + - description: PDM source enabled control mask
> + description:
> + The phandle to System Register Controller syscon node and the PDM source
> + from I2S enabled control offset and mask of SYS_SYSCON_NE register.
This description duplicates items. Drop redundant parts (there is really
never a need to say phandle is a phandle because it cannot be anything
else). Instead say what is it used for.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - resets
> + - '#sound-dai-cells'
Use consistent quotes, either ' or "
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-23 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 8:34 [PATCH v2 0/2] Add PDM controller for StarFive JH8100 SoC Xingyu Wu
2024-04-23 8:34 ` [PATCH v2 1/2] ASoC: dt-bindings: Add PDM controller for the " Xingyu Wu
2024-04-23 9:49 ` Krzysztof Kozlowski [this message]
2024-04-24 2:12 ` Xingyu Wu
2024-05-22 8:31 ` Xingyu Wu
2024-05-22 8:35 ` Xingyu Wu
2024-04-23 8:34 ` [PATCH v2 2/2] ASoC: starfive: Add PDM controller support Xingyu Wu
2024-05-22 2:11 ` Xingyu Wu
2024-05-22 11:22 ` Mark Brown
2024-05-23 1:48 ` Xingyu Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f8746f-14f8-4e56-9ac7-30c7ba6fad30@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=walker.chen@starfivetech.com \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).