From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Baojun Xu <baojun.xu@ti.com>
Cc: tiwai@suse.de, robh+dt@kernel.org, lgirdwood@gmail.com,
perex@perex.cz, pierre-louis.bossart@linux.intel.com,
kevin-lu@ti.com, shenghao-ding@ti.com, navada@ti.com,
13916275206@139.com, v-po@ti.com, niranjan.hy@ti.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
liam.r.girdwood@intel.com, yung-chuan.liao@linux.intel.com,
broonie@kernel.org, soyer@irl.hu
Subject: Re: [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add tas2781 driver for SPI
Date: Thu, 18 Apr 2024 14:56:35 +0300 [thread overview]
Message-ID: <ZiEKc4OTVlOt8llU@smile.fi.intel.com> (raw)
In-Reply-To: <20240418040240.2337-2-baojun.xu@ti.com>
On Thu, Apr 18, 2024 at 12:02:37PM +0800, Baojun Xu wrote:
> Integrate tas2781 configs for HP Laptops. Every tas2781 in the laptop
> will work as a single speaker on SPI bus. The code support realtek as
Realtek
> the primary codec.
...
> sound/pci/hda/Kconfig | 15 +++++++++++++++
> sound/pci/hda/Makefile | 2 ++
Is this correct? You are adding a dead "code", isn't it?
...
The rest LGTM.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-04-18 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 4:02 [PATCH v3 0/3] ALSA: hda/tas2781: Add tas2781 driver for SPI Baojun Xu
2024-04-18 4:02 ` [PATCH v3 1/3] ALSA: hda/tas2781: Modification for add " Baojun Xu
2024-04-18 11:56 ` Andy Shevchenko [this message]
2024-04-25 7:54 ` [EXTERNAL] " Xu, Baojun
2024-05-02 10:22 ` Andy Shevchenko
2024-05-06 7:44 ` Xu, Baojun
2024-05-06 8:44 ` Andy Shevchenko
2024-05-06 11:16 ` Takashi Iwai
2024-04-18 4:02 ` [PATCH v3 2/3] ALSA: hda/tas2781: Main code of " Baojun Xu
2024-04-18 14:03 ` Andy Shevchenko
2024-04-18 4:02 ` [PATCH v3 3/3] ALSA: hda/tas2781: Firmware load for " Baojun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiEKc4OTVlOt8llU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
--cc=v-po@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).