From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA Development Mailing List <alsa-devel@alsa-project.org>
Subject: Re: Missed review / mailing list submission?
Date: Tue, 23 Apr 2024 13:27:52 +0300 [thread overview]
Message-ID: <CAHp75VdUZ4ZLcXBSm8xq+sKuo_ny-VCcKYaBd2Ng+eGEjen5dg@mail.gmail.com> (raw)
In-Reply-To: <Zic9FJllBhOVtWr3@finisterre.sirena.org.uk>
On Tue, Apr 23, 2024 at 7:54 AM Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 22, 2024 at 09:28:45PM +0300, Andy Shevchenko wrote:
> > I can't find this in the mailing list.
>
> That was like v9 or something, as you later noticed it's been on the
> list over a very extended period with many revisions - there has been a
> more than adequate opportunity for review here (Pierre did a bunch for
> example).
Right, I simply looked at the wrong place, sorry.
> > Moreover, it has an obstacle to be applied, i.e. as per
> > https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
> > the gpio.h must not be included in a new code and brief looking into
> > that driver shows that legacy APIs are being used without _any_ good
> > reason.
>
> > This has to be fixed (by the author).
>
> Or someone else, for example you could do it if you were so moved.
Sure.
> You
> haven't even CCed Shenghao here... please at least send a mail to him
> explaining the issue.
I Cc'ed in the last of the three I have sent.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-04-23 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 18:28 Missed review / mailing list submission? Andy Shevchenko
2024-04-22 18:30 ` Andy Shevchenko
2024-04-22 18:33 ` Andy Shevchenko
2024-04-23 4:54 ` Mark Brown
2024-04-23 10:27 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VdUZ4ZLcXBSm8xq+sKuo_ny-VCcKYaBd2Ng+eGEjen5dg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).