From: Takashi Iwai <tiwai@suse.de>
To: Kailang <kailang@realtek.com>
Cc: " (alsa-devel@alsa-project.org)" <alsa-devel@alsa-project.org>
Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC
Date: Tue, 30 Apr 2024 11:48:17 +0200 [thread overview]
Message-ID: <87zftbmba6.wl-tiwai@suse.de> (raw)
In-Reply-To: <a853dc4f0a4e412381d5f60565181247@realtek.com>
On Tue, 30 Apr 2024 11:19:40 +0200,
Kailang wrote:
>
> Attached new patch.
OK, applied now.
thanks,
Takashi
> > -----Original Message-----
> > From: Takashi Iwai <tiwai@suse.de>
> > Sent: Thursday, April 18, 2024 11:37 PM
> > To: Kailang <kailang@realtek.com>
> > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC
> >
> >
> > External mail.
> >
> >
> >
> > On Thu, 18 Apr 2024 08:33:42 +0200,
> > Kailang wrote:
> > >
> > > Hi Takashi,
> > >
> > > New patch was attached.
> > > new additional function was request from Lenovo.
> >
> > I got a compile error. The check should be rather
> >
> > if (codec->core.dev.power.power_state.event == PM_EVENT_FREEZE)
> >
> > Maybe better to define is_s4_suspend() just like is_s4_resume().
> >
> > And, please rebase the patch to the latest for-linus branch of sound.git tree.
> >
> >
> > thanks,
> >
> > Takashi
> >
> > >
> > > BR,
> > > Kailang
> > >
> > > > -----Original Message-----
> > > > From: Takashi Iwai <tiwai@suse.de>
> > > > Sent: Thursday, April 18, 2024 2:22 PM
> > > > To: Kailang <kailang@realtek.com>
> > > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > > Subject: Re: Thinkpad with ALC1318 has a chance of damaging the IC
> > > >
> > > >
> > > > External mail.
> > > >
> > > >
> > > >
> > > > On Mon, 15 Apr 2024 11:27:50 +0200,
> > > > Kailang wrote:
> > > > >
> > > > > Hi Takashi,
> > > > >
> > > > > Please don't apply this patch.
> > > > > They want to add stream open to enable GPIO3 functions.
> > > >
> > > > OK, let me know if the new patch is ready.
> > > >
> > > >
> > > > thanks,
> > > >
> > > > Takashi
> > > >
> > > > >
> > > > > BR,
> > > > > Kailang
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Kailang
> > > > > > Sent: Wednesday, April 10, 2024 5:23 PM
> > > > > > To: Takashi Iwai (tiwai@suse.de) <tiwai@suse.de>
> > > > > > Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> > > > > > Subject: Thinkpad with ALC1318 has a chance of damaging the IC
> > > > > >
> > > > > > Hi Takashi,
> > > > > >
> > > > > > Thinkpad with ALC1318 has a chance of damaging the IC at S4 resume.
> > > > > >
> > > > > > BR,
> > > > > > Kailang
> > >
>
next prev parent reply other threads:[~2024-04-30 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 9:27 Thinkpad with ALC1318 has a chance of damaging the IC Kailang
2024-04-18 6:21 ` Takashi Iwai
2024-04-18 6:33 ` Kailang
2024-04-18 15:37 ` Takashi Iwai
2024-04-30 9:19 ` Kailang
2024-04-30 9:48 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-04-10 9:23 Kailang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zftbmba6.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).