From: Takashi Iwai <tiwai@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Baojun Xu <baojun.xu@ti.com>,
robh+dt@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
pierre-louis.bossart@linux.intel.com, kevin-lu@ti.com,
shenghao-ding@ti.com, navada@ti.com, 13916275206@139.com,
v-po@ti.com, niranjan.hy@ti.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
yung-chuan.liao@linux.intel.com, broonie@kernel.org,
soyer@irl.hu
Subject: Re: [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI
Date: Tue, 07 May 2024 15:05:08 +0200 [thread overview]
Message-ID: <87cypxeprv.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZjD1-NSC3X_7JcQg@smile.fi.intel.com>
On Tue, 30 Apr 2024 15:45:28 +0200,
Andy Shevchenko wrote:
>
> On Tue, Apr 30, 2024 at 02:58:10PM +0200, Takashi Iwai wrote:
> > On Tue, 30 Apr 2024 09:25:42 +0200, Baojun Xu wrote:
>
> ...
>
> > > snd-hda-cs-dsp-ctls-objs := hda_cs_dsp_ctl.o
> > > snd-hda-scodec-component-objs := hda_component.o
> > > snd-hda-scodec-tas2781-i2c-objs := tas2781_hda_i2c.o
> > > +snd-hda-scodec-tas2781-spi-y := tas2781_hda_spi.o tas2781_spi_fwlib.o
> >
> > A nitpicking: better to align with other lines (i.e. with *-objs
> > instead of *-y).
>
> I object this. The better approach is to have a precursor patch that switches
> to y over objs (the latter is for user space code / tools).
Indeed it can be a good cleanup, yeah. Let me try.
thanks,
Takashi
next prev parent reply other threads:[~2024-05-07 13:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 7:25 [PATCH v4 0/3] ALSA: hda/tas2781: Add tas2781 driver for SPI Baojun Xu
2024-04-30 7:25 ` [PATCH v4 1/3] ALSA: hda/tas2781: Add tas2781 hda driver based on SPI Baojun Xu
2024-04-30 12:58 ` Takashi Iwai
2024-04-30 13:45 ` Andy Shevchenko
2024-05-06 7:44 ` [EXTERNAL] " Xu, Baojun
2024-05-06 8:51 ` Andy Shevchenko
2024-05-07 13:05 ` Takashi Iwai [this message]
2024-04-30 13:44 ` Andy Shevchenko
2024-04-30 7:25 ` [PATCH v4 2/3] ALSA: hda/tas2781: Tas2781 hda driver for SPI Baojun Xu
2024-04-30 13:07 ` Takashi Iwai
2024-05-06 13:12 ` kernel test robot
2024-04-30 7:25 ` [PATCH v4 3/3] ALSA: hda/tas2781: Firmware load for tas2781 hda driver based on SPI Baojun Xu
2024-04-30 13:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cypxeprv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=kevin-lu@ti.com \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=navada@ti.com \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=v-po@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).