From: Takashi Iwai <tiwai@suse.de>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <tiwai@suse.com>, <linux-kernel@vger.kernel.org>,
<patches@opensource.cirrus.com>, <alsa-devel@alsa-project.org>,
<linux-sound@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback
Date: Wed, 08 May 2024 14:34:07 +0200 [thread overview]
Message-ID: <874jb8cwjk.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240508100347.47283-1-rf@opensource.cirrus.com>
On Wed, 08 May 2024 12:03:47 +0200,
Richard Fitzgerald wrote:
>
> Move the initialization of the shared struct hda_component array into
> hda_component_manager_bind().
>
> The purpose of the manager bind() callback is to allow it to perform
> initialization before binding in the component drivers. This is the
> correct place to initialize the shared data.
>
> The original implementation initialized the shared data in
> hda_component_manager_init(). This is only done once during probe()
> of the manager driver. So if the component binding was unbound and
> then rebound, the shared data would not be re-initialized.
>
> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
> Fixes: fd895a74dc1d ("ALSA: hda: realtek: Move hda_component implementation to module")
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2024-05-08 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 10:03 [PATCH] ALSA: hda: hda_component: Initialize shared data during bind callback Richard Fitzgerald
2024-05-08 12:34 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jb8cwjk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).