From: Takashi Iwai <tiwai@suse.de>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
broonie@kernel.org, "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Bard Liao" <yung-chuan.liao@linux.intel.com>,
"Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
Subject: Re: [PATCH] ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection
Date: Mon, 29 Apr 2024 17:03:04 +0200 [thread overview]
Message-ID: <8734r4p5xz.wl-tiwai@suse.de> (raw)
In-Reply-To: <20240426152818.38443-1-pierre-louis.bossart@linux.intel.com>
On Fri, 26 Apr 2024 17:28:18 +0200,
Pierre-Louis Bossart wrote:
>
> The SOF driver is selected whenever specific I2C/I2S HIDs are reported
> as 'present' in the ACPI DSDT. In some cases, an HID is reported but
> the hardware does not actually rely on I2C/I2S. This false positive
> leads to an invalid selection of the SOF driver and as a result an
> invalid topology is loaded.
>
> This patch hardens the detection with a check that the NHLT table is
> consistent with the report of an I2S-based codec in DSDT. This table
> should expose at least one SSP endpoint configured for an I2S-codec
> connection.
>
> Tested on Huawei Matebook D14 (NBLB-WAX9N) using an HDaudio codec with
> an invalid ES8336 ACPI HID reported:
>
> [ 7.858249] snd_hda_intel 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040380
> [ 7.858312] snd_hda_intel 0000:00:1f.3: snd_intel_dsp_find_config: no valid SSP found for HID ESSX8336, skipped
>
> Reported-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> Closes: https://github.com/thesofproject/linux/issues/4934
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
> Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Applied now. Thanks.
Takashi
prev parent reply other threads:[~2024-04-29 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 15:28 [PATCH] ALSA: hda: intel-dsp-config: harden I2C/I2S codec detection Pierre-Louis Bossart
2024-04-29 15:03 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734r4p5xz.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).