From: WTLI <wtli@nuvoton.com>
To: Rob Herring <robh@kernel.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-sound@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
perex@perex.cz, tiwai@suse.com, YHCHuang@nuvoton.com,
KCHSU0@nuvoton.com, CTLIN0@nuvoton.com, SJLIN0@nuvoton.com,
scott6986@gmail.com, supercraig0719@gmail.com,
dardar923@gmail.com, edson.drosdeck@gmail.com,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC
Date: Mon, 15 Apr 2024 10:32:29 +0800 [thread overview]
Message-ID: <81fa2939-37b8-479b-a03b-1f2ea17b2131@nuvoton.com> (raw)
In-Reply-To: <20240412155220.GA2918590-robh@kernel.org>
Rob Herring 於 4/12/2024 11:52 PM 寫道:
> CAUTION - External Email: Do not click links or open attachments unless you acknowledge the sender and content.
>
>
> On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote:
>> Change the original fixed delay to the assignment from the property. It
>> will make it more flexible to different platforms to avoid pop noise at
>> the beginning of recording.
>>
>> Signed-off-by: Seven Lee <wtli@nuvoton.com>
>> ---
>> .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> index 054b53954ac3..a726c5a9b067 100644
>> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
>> @@ -103,6 +103,13 @@ properties:
>> just limited to the left adc for design demand.
>> type: boolean
>>
>> + nuvoton,adc-delay-ms:
>> + description: Delay (in ms) to make input path stable and avoid pop noise.
>> + The default value is 125 and range between 125 to 500 ms.
> No need to state constraints in prose.
okay, I will fix it.
>
>> + minimum: 125
>> + maximum: 500
>> + default: 125
>> +
>> '#sound-dai-cells':
>> const: 0
>>
>> @@ -136,6 +143,7 @@ examples:
>> nuvoton,jack-eject-debounce = <0>;
>> nuvoton,dmic-clk-threshold = <3072000>;
>> nuvoton,dmic-slew-rate = <0>;
>> + nuvoton,nuvoton,adc-delay-ms = <125>;
>> #sound-dai-cells = <0>;
>> };
>> };
>> --
>> 2.25.1
>>
________________________________
________________________________
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
prev parent reply other threads:[~2024-04-15 2:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 10:35 [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC Seven Lee
2024-04-12 10:35 ` [PATCH 2/3] ASoC: " Seven Lee
2024-04-12 10:35 ` [PATCH 3/3] ASoC: nau8821: Remove redundant ADC controls Seven Lee
2024-04-12 11:17 ` [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC Rob Herring
2024-04-12 15:52 ` Rob Herring
2024-04-15 2:32 ` WTLI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81fa2939-37b8-479b-a03b-1f2ea17b2131@nuvoton.com \
--to=wtli@nuvoton.com \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=SJLIN0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dardar923@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=edson.drosdeck@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=scott6986@gmail.com \
--cc=supercraig0719@gmail.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).