From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: shumingf@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: alsa-devel@alsa-project.org, lars@metafoo.de, flove@realtek.com,
oder_chiou@realtek.com, jack.yu@realtek.com,
derek.fang@realtek.com
Subject: Re: [PATCH] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver
Date: Wed, 15 May 2024 08:23:43 -0500 [thread overview]
Message-ID: <790667c8-2893-47d6-b47a-340ac12af28c@linux.intel.com> (raw)
In-Reply-To: <20240515085939.201081-1-shumingf@realtek.com>
> +static const struct reg_sequence rt1320_blind_write[] = {
...
> +};
> +
> +static const struct reg_sequence rt1320_patch_code_write[] = {
...
> +};
On GitHub we talked about using the SDCA Initialization table coming
from ACPI, is this still something you're interested in?
> + if (rt1320->version_id < 0) {
> + regmap_read(rt1320->regmap, RT1320_DEV_VERSION_ID_1, &val);
> + rt1320->version_id = val;
> + /*
> + * We call the version b which has the new DSP ROM code against version a.
> + * Therefore, we read the DSP address to check the ID.
> + */
> + if (val == RT1320_VER_B_ID)
> + rt1320->version_id = RT1320_VB;
> + regmap_write(rt1320->regmap, SDW_SDCA_CTL(FUNC_NUM_AMP, RT1320_SDCA_ENT_PDE23,
> + RT1320_SDCA_CTL_REQ_POWER_STATE, 0), 3);
> + }
> + dev_dbg(dev, "%s version_id=%d\n", __func__, rt1320->version_id);
Maybe I missed it but I didn't see anything that tests the version_id
and does something different between VER_A and VER_B. Can you add a
comment on why it's important to track the version?
Also if there's a DSP, is there a need for the FDL capability to
download firmware, or is the speaker protection configured only via tables?
next prev parent reply other threads:[~2024-05-15 13:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 8:59 [PATCH] ASoC: rt1320: Add RT1320 SDCA vendor-specific driver shumingf
2024-05-15 13:23 ` Pierre-Louis Bossart [this message]
2024-05-16 3:22 ` Shuming [范書銘]
2024-05-16 14:44 ` Pierre-Louis Bossart
2024-05-17 5:49 ` Shuming [范書銘]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=790667c8-2893-47d6-b47a-340ac12af28c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).