* [PATCH resend] ASoC: wm8741: Fix rates constraints values
@ 2015-03-24 20:13 Sergej Sawazki
2015-03-25 9:06 ` Charles Keepax
2015-03-25 15:27 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Sergej Sawazki @ 2015-03-24 20:13 UTC (permalink / raw
To: broonie; +Cc: Sergej Sawazki, alsa-devel, patches, lgirdwood, lars
The WM8741 DAC supports the following typical audio sampling rates:
44.1kHz, 88.2kHz, 176.4kHz (eg: with a master clock of 22.5792MHz)
32kHz, 48kHz, 96kHz, 192kHz (eg: with a master clock of 24.576MHz)
For the rates lists, we should use 82000 instead of 88235, 176400
instead of 1764000 and 192000 instead of 19200 (seems to be a typo).
Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
---
sound/soc/codecs/wm8741.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c
index 31bb480..9e71c76 100644
--- a/sound/soc/codecs/wm8741.c
+++ b/sound/soc/codecs/wm8741.c
@@ -123,7 +123,7 @@ static struct {
};
static const unsigned int rates_11289[] = {
- 44100, 88235,
+ 44100, 88200,
};
static const struct snd_pcm_hw_constraint_list constraints_11289 = {
@@ -150,7 +150,7 @@ static const struct snd_pcm_hw_constraint_list constraints_16384 = {
};
static const unsigned int rates_16934[] = {
- 44100, 88235,
+ 44100, 88200,
};
static const struct snd_pcm_hw_constraint_list constraints_16934 = {
@@ -168,7 +168,7 @@ static const struct snd_pcm_hw_constraint_list constraints_18432 = {
};
static const unsigned int rates_22579[] = {
- 44100, 88235, 1764000
+ 44100, 88200, 176400
};
static const struct snd_pcm_hw_constraint_list constraints_22579 = {
@@ -186,7 +186,7 @@ static const struct snd_pcm_hw_constraint_list constraints_24576 = {
};
static const unsigned int rates_36864[] = {
- 48000, 96000, 19200
+ 48000, 96000, 192000
};
static const struct snd_pcm_hw_constraint_list constraints_36864 = {
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] ASoC: wm8741: Fix rates constraints values
2015-03-24 20:13 [PATCH resend] ASoC: wm8741: Fix rates constraints values Sergej Sawazki
@ 2015-03-25 9:06 ` Charles Keepax
2015-03-25 15:27 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2015-03-25 9:06 UTC (permalink / raw
To: Sergej Sawazki; +Cc: alsa-devel, broonie, patches, lars, lgirdwood
On Tue, Mar 24, 2015 at 09:13:22PM +0100, Sergej Sawazki wrote:
> The WM8741 DAC supports the following typical audio sampling rates:
> 44.1kHz, 88.2kHz, 176.4kHz (eg: with a master clock of 22.5792MHz)
> 32kHz, 48kHz, 96kHz, 192kHz (eg: with a master clock of 24.576MHz)
>
> For the rates lists, we should use 82000 instead of 88235, 176400
> instead of 1764000 and 192000 instead of 19200 (seems to be a typo).
>
> Signed-off-by: Sergej Sawazki <ce3a@gmx.de>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
I already ACKed the last version of this patch, helps if you
apply my ACK in the commit message if you are resending and
haven't changed the patch.
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] ASoC: wm8741: Fix rates constraints values
2015-03-24 20:13 [PATCH resend] ASoC: wm8741: Fix rates constraints values Sergej Sawazki
2015-03-25 9:06 ` Charles Keepax
@ 2015-03-25 15:27 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-03-25 15:27 UTC (permalink / raw
To: Sergej Sawazki; +Cc: alsa-devel, patches, lgirdwood, lars
[-- Attachment #1.1: Type: text/plain, Size: 294 bytes --]
On Tue, Mar 24, 2015 at 09:13:22PM +0100, Sergej Sawazki wrote:
> The WM8741 DAC supports the following typical audio sampling rates:
> 44.1kHz, 88.2kHz, 176.4kHz (eg: with a master clock of 22.5792MHz)
> 32kHz, 48kHz, 96kHz, 192kHz (eg: with a master clock of 24.576MHz)
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-25 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24 20:13 [PATCH resend] ASoC: wm8741: Fix rates constraints values Sergej Sawazki
2015-03-25 9:06 ` Charles Keepax
2015-03-25 15:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).