From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: "Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
kernel@pengutronix.de
Subject: Re: [PATCH] slimbus: Convert to platform remove callback returning void
Date: Thu, 11 Apr 2024 10:49:26 +0100 [thread overview]
Message-ID: <171282896694.158118.17443154512490212488.b4-ty@linaro.org> (raw)
In-Reply-To: <20240225001911.46196-2-u.kleine-koenig@pengutronix.de>
On Sun, 25 Feb 2024 01:19:12 +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>
> [...]
Applied, thanks!
[1/1] slimbus: Convert to platform remove callback returning void
commit: f6c637ffe528068f5470551a1424f173a139d0c7
Best regards,
--
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
prev parent reply other threads:[~2024-04-11 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 0:19 [PATCH] slimbus: Convert to platform remove callback returning void Uwe Kleine-König
2024-04-09 16:22 ` Uwe Kleine-König
2024-04-11 9:49 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171282896694.158118.17443154512490212488.b4-ty@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).