* [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
@ 2023-12-05 22:01 cujomalainey
2023-12-06 14:21 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: cujomalainey @ 2023-12-05 22:01 UTC (permalink / raw)
To: alsa-devel
Cc: Curtis Malainey, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, AngeloGioacchino Del Regno, Trevor Wu,
Tinghan Shen
From: Curtis Malainey <cujomalainey@chromium.org>
This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
This is not an official topology from the SOF project. Topologies are
named based on the card configuration and are NOT board specific.
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
---
sound/soc/sof/mediatek/mt8186/mt8186.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/sof/mediatek/mt8186/mt8186.c b/sound/soc/sof/mediatek/mt8186/mt8186.c
index 1d37c9767986f..0d2d7d697de02 100644
--- a/sound/soc/sof/mediatek/mt8186/mt8186.c
+++ b/sound/soc/sof/mediatek/mt8186/mt8186.c
@@ -548,9 +548,6 @@ static struct snd_sof_dsp_ops sof_mt8186_ops = {
static struct snd_sof_of_mach sof_mt8186_machs[] = {
{
- .compatible = "google,steelix",
- .sof_tplg_filename = "sof-mt8186-google-steelix.tplg"
- }, {
.compatible = "mediatek,mt8186",
.sof_tplg_filename = "sof-mt8186.tplg",
},
--
2.43.0.rc2.451.g8631bc7472-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
2023-12-05 22:01 [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible cujomalainey
@ 2023-12-06 14:21 ` Mark Brown
2023-12-06 18:51 ` Curtis Malainey
2023-12-06 14:32 ` AngeloGioacchino Del Regno
2023-12-06 21:04 ` Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2023-12-06 14:21 UTC (permalink / raw)
To: cujomalainey
Cc: alsa-devel, Pierre-Louis Bossart, Liam Girdwood, Peter Ujfalusi,
Bard Liao, Ranjani Sridharan, Daniel Baluta, Kai Vehmanen,
Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
AngeloGioacchino Del Regno, Trevor Wu, Tinghan Shen
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Tue, Dec 05, 2023 at 02:01:18PM -0800, cujomalainey@chromium.org wrote:
> From: Curtis Malainey <cujomalainey@chromium.org>
>
> This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
2023-12-05 22:01 [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible cujomalainey
2023-12-06 14:21 ` Mark Brown
@ 2023-12-06 14:32 ` AngeloGioacchino Del Regno
2023-12-06 18:21 ` Curtis Malainey
2023-12-06 21:04 ` Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-12-06 14:32 UTC (permalink / raw)
To: cujomalainey, alsa-devel
Cc: Pierre-Louis Bossart, Liam Girdwood, Peter Ujfalusi, Bard Liao,
Ranjani Sridharan, Daniel Baluta, Kai Vehmanen, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Matthias Brugger, Trevor Wu,
Tinghan Shen
Il 05/12/23 23:01, cujomalainey@chromium.org ha scritto:
> From: Curtis Malainey <cujomalainey@chromium.org>
>
> This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
>
> This is not an official topology from the SOF project. Topologies are
> named based on the card configuration and are NOT board specific.
>
While I can totally agree with that, can you please explain how should the correct
topology file name be selected instead of machine compatibles?
Thanks,
Angelo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
2023-12-06 14:32 ` AngeloGioacchino Del Regno
@ 2023-12-06 18:21 ` Curtis Malainey
0 siblings, 0 replies; 6+ messages in thread
From: Curtis Malainey @ 2023-12-06 18:21 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: cujomalainey, alsa-devel, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, Trevor Wu, Tinghan Shen
On Wed, Dec 6, 2023 at 6:32 AM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 05/12/23 23:01, cujomalainey@chromium.org ha scritto:
> > From: Curtis Malainey <cujomalainey@chromium.org>
> >
> > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
> >
> > This is not an official topology from the SOF project. Topologies are
> > named based on the card configuration and are NOT board specific.
> >
>
> While I can totally agree with that, can you please explain how should the correct
> topology file name be selected instead of machine compatibles?
>
> Thanks,
> Angelo
The typical convention is if there is more than one configuration with
an SoC to suffix with the components involved. Additional suffixes can
be added for special cases e.g. for Intel
sof-tgl-rt5682-max98357a.tplg where tgl is the SoC family, rt5682 is
the codec and max98357a is the amp. You can find examples where the
pin mapping was changed accidentally on some boards so you will see
suffixes like "-up4". Public suffixes/topologies do not include 3P
blocks.
Curtis
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
2023-12-06 14:21 ` Mark Brown
@ 2023-12-06 18:51 ` Curtis Malainey
0 siblings, 0 replies; 6+ messages in thread
From: Curtis Malainey @ 2023-12-06 18:51 UTC (permalink / raw)
To: Mark Brown
Cc: cujomalainey, alsa-devel, Pierre-Louis Bossart, Liam Girdwood,
Peter Ujfalusi, Bard Liao, Ranjani Sridharan, Daniel Baluta,
Kai Vehmanen, Jaroslav Kysela, Takashi Iwai, Matthias Brugger,
AngeloGioacchino Del Regno, Trevor Wu, Tinghan Shen
On Wed, Dec 6, 2023 at 6:21 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Dec 05, 2023 at 02:01:18PM -0800, cujomalainey@chromium.org wrote:
> > From: Curtis Malainey <cujomalainey@chromium.org>
> >
> > This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.
Apologies, here is a user friendly summary
ASoC: SOF: mediatek: mt8186: Revert "ASoC: SOF: mediatek: mt8186: Add
Google Steelix topology compatible"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
2023-12-05 22:01 [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible cujomalainey
2023-12-06 14:21 ` Mark Brown
2023-12-06 14:32 ` AngeloGioacchino Del Regno
@ 2023-12-06 21:04 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2023-12-06 21:04 UTC (permalink / raw)
To: alsa-devel, cujomalainey
Cc: Pierre-Louis Bossart, Liam Girdwood, Peter Ujfalusi, Bard Liao,
Ranjani Sridharan, Daniel Baluta, Kai Vehmanen, Jaroslav Kysela,
Takashi Iwai, Matthias Brugger, AngeloGioacchino Del Regno,
Trevor Wu, Tinghan Shen
On Tue, 05 Dec 2023 14:01:18 -0800, cujomalainey@chromium.org wrote:
> This reverts commit 505c83212da5bfca95109421b8f5d9f8c6cdfef2.
>
> This is not an official topology from the SOF project. Topologies are
> named based on the card configuration and are NOT board specific.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible
commit: d20d36755a605a21e737b6b16c566658589b1811
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-06 21:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 22:01 [PATCH] ASoC: SOF: mediatek: mt8186: Revert Add Google Steelix topology compatible cujomalainey
2023-12-06 14:21 ` Mark Brown
2023-12-06 18:51 ` Curtis Malainey
2023-12-06 14:32 ` AngeloGioacchino Del Regno
2023-12-06 18:21 ` Curtis Malainey
2023-12-06 21:04 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).