* [PATCH v5] ufs: core: correct ufshcd_shutdown flow
@ 2022-07-27 3:05 peter.wang
2022-07-27 3:11 ` Stanley Chu
2022-08-01 23:33 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: peter.wang @ 2022-07-27 3:05 UTC (permalink / raw
To: stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, peter.wang, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, stable
From: Peter Wang <peter.wang@mediatek.com>
After ufshcd_wl_shutdown set device power off and link off,
ufshcd_shutdown could turn off clock/power.
Also remove pm_runtime_get_sync.
The reason why here can remove pm_runtime_get_sync is because,
(1) ufshcd_wl_shutdown -> pm_runtime_get_sync, will resume hba->dev too.
(2) device resume(turn on clk/power) is not required, even if device is in RPM_SUSPENDED.
Fixes: b294ff3e3449 ("scsi: ufs: core: Enable power management for wlun")
Cc: <stable@vger.kernel.org> # 5.15.x
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/ufs/core/ufshcd.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c7b337480e3e..d13c76983555 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -9462,12 +9462,8 @@ EXPORT_SYMBOL(ufshcd_runtime_resume);
int ufshcd_shutdown(struct ufs_hba *hba)
{
if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba))
- goto out;
-
- pm_runtime_get_sync(hba->dev);
+ ufshcd_suspend(hba);
- ufshcd_suspend(hba);
-out:
hba->is_powered = false;
/* allow force shutdown even in case of errors */
return 0;
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5] ufs: core: correct ufshcd_shutdown flow
2022-07-27 3:05 [PATCH v5] ufs: core: correct ufshcd_shutdown flow peter.wang
@ 2022-07-27 3:11 ` Stanley Chu
2022-08-01 23:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Stanley Chu @ 2022-07-27 3:11 UTC (permalink / raw
To: peter.wang
Cc: Stanley Chu, linux-scsi, Martin K . Petersen, Avri Altman,
alim.akhtar, James E.J. Bottomley, wsd_upstream, linux-mediatek,
Chun-Hung Wu, alice.chao, cc.chou, chaotian.jing, jiajie.hao,
powen.kao, qilin.tan, lin.gui, stable
On Wed, Jul 27, 2022 at 11:10 AM <peter.wang@mediatek.com> wrote:
>
> From: Peter Wang <peter.wang@mediatek.com>
>
> After ufshcd_wl_shutdown set device power off and link off,
> ufshcd_shutdown could turn off clock/power.
>
> Also remove pm_runtime_get_sync.
> The reason why here can remove pm_runtime_get_sync is because,
> (1) ufshcd_wl_shutdown -> pm_runtime_get_sync, will resume hba->dev too.
> (2) device resume(turn on clk/power) is not required, even if device is in RPM_SUSPENDED.
>
> Fixes: b294ff3e3449 ("scsi: ufs: core: Enable power management for wlun")
> Cc: <stable@vger.kernel.org> # 5.15.x
> Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5] ufs: core: correct ufshcd_shutdown flow
2022-07-27 3:05 [PATCH v5] ufs: core: correct ufshcd_shutdown flow peter.wang
2022-07-27 3:11 ` Stanley Chu
@ 2022-08-01 23:33 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-08-01 23:33 UTC (permalink / raw
To: peter.wang
Cc: stanley.chu, linux-scsi, martin.petersen, avri.altman,
alim.akhtar, jejb, wsd_upstream, linux-mediatek, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, stable
> After ufshcd_wl_shutdown set device power off and link off,
> ufshcd_shutdown could turn off clock/power.
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-01 23:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-27 3:05 [PATCH v5] ufs: core: correct ufshcd_shutdown flow peter.wang
2022-07-27 3:11 ` Stanley Chu
2022-08-01 23:33 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.