From: Sau Dan Lee <danlee@informatik.uni-freiburg.de>
To: linux-kernel@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>
Subject: [PATCH] Bug Fix: 2.6.{5,6,7-rc1}: i8042 module unload bug
Date: 24 May 2004 09:56:42 +0200 [thread overview]
Message-ID: <xb7hdu6i7gl.fsf@savona.informatik.uni-freiburg.de> (raw)
In-Reply-To: xb71xlwtz9s.fsf@savona.informatik.uni-freiburg.de
I'm wondering why 2.6.7-rc1 does NOT contain the following patch.
See: http://lkml.org/lkml/2004/5/10/63
--- linux-2.6.7-rc1/drivers/input/serio/i8042.c
+++ linux-2.6.7-rc1.i8042-shutdown-fix/drivers/input/serio/i8042.c
@@ -990,24 +990,28 @@
unregister_reboot_notifier(&i8042_notifier);
if (i8042_pm_dev)
pm_unregister(i8042_pm_dev);
if (i8042_sysdev_initialized) {
sysdev_unregister(&device_i8042);
sysdev_class_unregister(&kbc_sysclass);
}
- del_timer_sync(&i8042_timer);
-
i8042_controller_cleanup();
+ /* we must delete the timer AFTER the i8042 chip is cleaned up,
+ so as to prevent any more interrupts to invoke i8042_interrupt()
+ which then schedules newer timer events.
+ */
+ del_timer_sync(&i8042_timer);
+
if (i8042_kbd_values.exists)
serio_unregister_port(&i8042_kbd_port);
if (i8042_aux_values.exists)
serio_unregister_port(&i8042_aux_port);
for (i = 0; i < 4; i++)
if (i8042_mux_values[i].exists)
serio_unregister_port(i8042_mux_port + i);
--
Sau Dan LEE 李守敦(Big5) ~{@nJX6X~}(HZ)
E-mail: danlee@informatik.uni-freiburg.de
Home page: http://www.informatik.uni-freiburg.de/~danlee
prev parent reply other threads:[~2004-05-24 7:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 14:36 Bug Report: 2.6.5 broken module dependencies: i8042 and atkbd? Sau Dan Lee
2004-05-03 8:21 ` [PATCH] (fix:oops with rmmod i8042) (was:Bug Report: 2.6.5 broken module dependencies: i8042 and atkbd?) Tuukka Toivonen
2004-05-03 11:46 ` [PATCH] modused: mark some modules as in use (Re: [PATCH] (fix:oops with rmmod i8042)) Sau Dan Lee
2004-05-07 8:30 ` [PATCH] Bug Fix: 2.6.5 broken module dependencies: i8042 and atkbd? Sau Dan Lee
2004-05-10 12:12 ` [PATCH] Bug Fix: 2.6.{5,6}: i8042 module unload bug Sau Dan Lee
2004-05-24 7:56 ` Sau Dan Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xb7hdu6i7gl.fsf@savona.informatik.uni-freiburg.de \
--to=danlee@informatik.uni-freiburg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.