From: "werner" <w.landgraf@ru.ru>
To: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org,
maciej.rutecki@gmail.com, florian@mickler.org
Subject: Re: [Bug #42669] 3.3-rc1: compiling problems nvme , l2cap_sock , mc13892-regulator , and snd-pcsp don't work
Date: Fri, 24 Feb 2012 06:48:58 -0400 [thread overview]
Message-ID: <web-701709481@zbackend1.aha.ru> (raw)
In-Reply-To: <20120223.181904.501214130038312055.davem@davemloft.net>
But why then the error is still in the source code, at
least until the last 3.3-rc4 ??? I also compiled the
code, removing always inline from the line as in the
patch, then it works.
Also, the other compiling errors what I reclaim about,
aren't yet resolved.
This things happens, because people, after changes, nor
compile them subroutines ... :( Much less, test them
...
W.Landgraf
=============================================================
On Thu, 23 Feb 2012 18:19:04 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
>From: "Rafael J. Wysocki" <rjw@sisk.pl>
> Date: Thu, 23 Feb 2012 23:51:25 +0100 (CET)
>
>> This message has been generated automatically as a part
>>of a summary report
>> of recent regressions.
>>
>> The following bug entry is on the current list of known
>>regressions
>> from 3.2. Please verify if it still should be listed
>>and let the tracking team
>> know (either way).
>>
>>
>> Bug-Entry :
>>http://bugzilla.kernel.org/show_bug.cgi?id=42669
>> Subject : 3.3-rc1: compiling problems nvme ,
>>l2cap_sock , mc13892-regulator , and snd-pcsp don't work
>> Submitter : werner <w.landgraf@ru.ru>
>> Date : 2012-01-20 18:52 (35 days old)
>> Message-ID : <web-682421181@zbackend1.aha.ru>
>> References :
>>http://marc.info/?l=linux-kernel&m=132708923719565&w=2
>
> The l2cap_sock problem is fixed in the net GIT tree by
>commit:
>
> --------------------
> commit 4aa832c27edf902130f8bace1d42cf22468823fa
> Author: Johan Hedberg <johan.hedberg@intel.com>
> Date: Sun Jan 8 22:51:16 2012 +0200
>
> Bluetooth: Remove bogus inline declaration from
>l2cap_chan_connect
>
> As reported by Dan Carpenter this function causes a
>Sparse warning and
> shouldn't be declared inline:
>
> include/net/bluetooth/l2cap.h:837:30 error: marked
>inline, but without a
> definition"
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Johan Hedberg
><johan.hedberg@intel.com>
> Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> diff --git a/include/net/bluetooth/l2cap.h
>b/include/net/bluetooth/l2cap.h
> index 68f5891..124f7cf 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -834,7 +834,7 @@ int l2cap_add_scid(struct l2cap_chan
>*chan, __u16 scid);
> struct l2cap_chan *l2cap_chan_create(struct sock *sk);
> void l2cap_chan_close(struct l2cap_chan *chan, int
>reason);
> void l2cap_chan_destroy(struct l2cap_chan *chan);
> -inline int l2cap_chan_connect(struct l2cap_chan *chan,
>__le16 psm, u16 cid,
> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16
>psm, u16 cid,
> bdaddr_t *dst);
> int l2cap_chan_send(struct l2cap_chan *chan, struct
>msghdr *msg, size_t len,
> u32 priority);
> diff --git a/net/bluetooth/l2cap_core.c
>b/net/bluetooth/l2cap_core.c
> index faf0b11..980abdb 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -1120,7 +1120,7 @@ static struct l2cap_chan
>*l2cap_global_chan_by_psm(int state, __le16 psm, bdaddr
> return c1;
> }
>
> -inline int l2cap_chan_connect(struct l2cap_chan *chan,
>__le16 psm, u16 cid, bdaddr_t *dst)
> +int l2cap_chan_connect(struct l2cap_chan *chan, __le16
>psm, u16 cid, bdaddr_t *dst)
> {
> struct sock *sk = chan->sk;
> bdaddr_t *src = &bt_sk(sk)->src;
>
>
"werner" <w.landgraf@ru.ru>
---
Professional hosting for everyone - http://www.host.ru
next prev parent reply other threads:[~2012-02-24 10:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 22:51 3.3-rc4+: Reported regressions from 3.2 Rafael J. Wysocki
2012-02-23 22:51 ` Rafael J. Wysocki
2012-02-23 22:51 ` [Bug #42669] 3.3-rc1: compiling problems nvme , l2cap_sock , mc13892-regulator , and snd-pcsp don't work Rafael J. Wysocki
2012-02-23 23:19 ` David Miller
2012-02-23 23:19 ` David Miller
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-23 23:30 ` Rafael J. Wysocki
2012-02-24 10:48 ` werner [this message]
2012-02-24 19:57 ` David Miller
2012-02-24 19:57 ` David Miller
2012-02-24 21:55 ` werner
2012-02-24 21:55 ` werner
2012-02-25 22:48 ` Florian Mickler
2012-02-23 22:55 ` [Bug #42686] iwlagn is getting even worse with 3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42678] [3.3-rc1] radeon stuck in kernel after lockup Rafael J. Wysocki
2012-02-24 9:14 ` Torsten Kaiser
2012-02-24 9:14 ` Torsten Kaiser
2012-02-23 22:55 ` [Bug #42707] Hang deconfiguring network interface (in shutdown) on 3.3-rc1 Rafael J. Wysocki
2012-02-27 23:44 ` James Bottomley
2012-02-28 1:24 ` Matt Carlson
2012-02-28 21:07 ` David Miller
2012-02-28 21:07 ` David Miller
2012-02-28 23:32 ` Matt Carlson
2012-02-28 23:32 ` Matt Carlson
2012-02-29 0:58 ` James Bottomley
2012-02-29 0:58 ` James Bottomley
2012-02-29 9:33 ` Michael Chan
2012-02-29 18:46 ` David Miller
2012-02-29 18:46 ` David Miller
2012-02-23 22:55 ` [Bug #42683] WARN... Device 'cpu1' does not have a release() function, it is broken and must be fixed. when doing 'xl vcpu-set <guest_id> 1' Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-24 4:33 ` Konrad Rzeszutek Wilk
2012-02-23 22:55 ` [Bug #42735] kobject (ffff88003ffbb4b8): tried to init an initialized object, something is seriously wrong Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42734] dosemu graphics broken in v3.3-rc1 Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42733] Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42746] 3.3-rc2 snd_pcm lockdep backtrace Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42713] Regression in skge that started around acb42a3 (so past v3.3-rc1) Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42798] i915 regression with 3.3-rc3+git Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42776] OF-related boot crash in 3.3.0-rc3-00188-g3ec1e88 Rafael J. Wysocki
2012-02-23 22:55 ` [Bug #42761] Possible circular locking dependency (3.3-rc2) Rafael J. Wysocki
2012-02-23 22:55 ` Rafael J. Wysocki
2012-02-23 23:28 ` 3.3-rc4+: Reported regressions from 3.2 David Miller
2012-02-23 23:28 ` David Miller
2012-02-24 0:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=web-701709481@zbackend1.aha.ru \
--to=w.landgraf@ru.ru \
--cc=davem@davemloft.net \
--cc=florian@mickler.org \
--cc=kernel-testers@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.rutecki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.