From: tip-bot for Ingo Molnar <mingo@elte.hu>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
a.p.zijlstra@chello.nl, torvalds@linux-foundation.org,
efault@gmx.de, tglx@linutronix.de, mingo@elte.hu
Subject: [tip:sched/urgent] sched: Remove debugging check
Date: Mon, 20 Dec 2010 08:37:31 GMT [thread overview]
Message-ID: <tip-050c6c9b896625d9fa498265be17b82c5fc65257@git.kernel.org> (raw)
In-Reply-To: <AANLkTinJ8hAG1TpyC+CSYPR47p48+1=E7fiC45hMXT_1@mail.gmail.com>
Commit-ID: 050c6c9b896625d9fa498265be17b82c5fc65257
Gitweb: http://git.kernel.org/tip/050c6c9b896625d9fa498265be17b82c5fc65257
Author: Ingo Molnar <mingo@elte.hu>
AuthorDate: Sun, 19 Dec 2010 23:24:27 +0100
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 19 Dec 2010 23:24:27 +0100
sched: Remove debugging check
Linus reported that the new warning introduced by commit f26f9aff6aaf
"Sched: fix skip_clock_update optimization" triggers. The need_resched
flag can be set by other CPUs asynchronously so this debug check is
bogus - remove it.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <AANLkTinJ8hAG1TpyC+CSYPR47p48+1=E7fiC45hMXT_1@mail.gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/sched.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 456c990..297d1a0 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4128,7 +4128,6 @@ need_resched_nonpreemptible:
rq->nr_switches++;
rq->curr = next;
++*switch_count;
- WARN_ON_ONCE(test_tsk_need_resched(next));
context_switch(rq, prev, next); /* unlocks the rq */
/*
next prev parent reply other threads:[~2010-12-20 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-19 15:27 [GIT PULL] scheduler fixes Ingo Molnar
2010-12-19 20:45 ` Linus Torvalds
2010-12-19 22:30 ` [GIT PULL, v2] " Ingo Molnar
2010-12-20 8:37 ` tip-bot for Ingo Molnar [this message]
2010-12-20 10:15 ` [GIT PULL] " Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-050c6c9b896625d9fa498265be17b82c5fc65257@git.kernel.org \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.