* [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
@ 2008-04-29 20:46 Ingo Molnar
2008-04-30 10:41 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-04-29 20:46 UTC (permalink / raw
To: linux-kernel; +Cc: Takashi Iwai, Mauro Carvalho Chehab
fix build failure triggered on latest -git by this config:
http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad
sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known
the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT
APIs.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
sound/pci/Kconfig | 1 +
1 file changed, 1 insertion(+)
Index: linux/sound/pci/Kconfig
===================================================================
--- linux.orig/sound/pci/Kconfig
+++ linux/sound/pci/Kconfig
@@ -529,6 +529,7 @@ config SND_FM801_TEA575X
depends on SND_FM801_TEA575X_BOOL
default SND_FM801
select VIDEO_V4L1
+ select VIDEO_V4L1_COMPAT
select VIDEO_DEV
config SND_HDA_INTEL
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
2008-04-29 20:46 [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug Ingo Molnar
@ 2008-04-30 10:41 ` Takashi Iwai
2008-05-07 19:36 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2008-04-30 10:41 UTC (permalink / raw
To: Ingo Molnar; +Cc: linux-kernel, Mauro Carvalho Chehab
At Tue, 29 Apr 2008 22:46:43 +0200,
Ingo Molnar wrote:
>
>
> fix build failure triggered on latest -git by this config:
>
> http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad
>
> sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
> sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
> sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
> sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
> sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known
>
> the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT
> APIs.
I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things
messy enough. And more select, eh... IMO, this should be rather
depend on VIDEO_V4L1.
But, there is a dependency chain problem among snd-fm801,
snd-fm801-tea575x and V4L layer. I'll check it.
Takashi
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> sound/pci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/sound/pci/Kconfig
> ===================================================================
> --- linux.orig/sound/pci/Kconfig
> +++ linux/sound/pci/Kconfig
> @@ -529,6 +529,7 @@ config SND_FM801_TEA575X
> depends on SND_FM801_TEA575X_BOOL
> default SND_FM801
> select VIDEO_V4L1
> + select VIDEO_V4L1_COMPAT
> select VIDEO_DEV
>
> config SND_HDA_INTEL
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
2008-04-30 10:41 ` Takashi Iwai
@ 2008-05-07 19:36 ` Mauro Carvalho Chehab
2008-05-08 10:33 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Mauro Carvalho Chehab @ 2008-05-07 19:36 UTC (permalink / raw
To: Takashi Iwai; +Cc: Ingo Molnar, linux-kernel
On Wed, 30 Apr 2008 12:41:52 +0200
Takashi Iwai <tiwai@suse.de> wrote:
Takashi,
I'm assuming that you're handing this issue, right?
> > Index: linux/sound/pci/Kconfig
> > ===================================================================
> > --- linux.orig/sound/pci/Kconfig
> > +++ linux/sound/pci/Kconfig
> > @@ -529,6 +529,7 @@ config SND_FM801_TEA575X
> > depends on SND_FM801_TEA575X_BOOL
> > default SND_FM801
> > select VIDEO_V4L1
> > + select VIDEO_V4L1_COMPAT
> > select VIDEO_DEV
Hmm... VIDEO_V4L1 where renamed as VIDEO_ALLOW_V4L1. Probably, this is what's
broken for SND_FM801_TEA575X.
Cheers,
Mauro
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug
2008-05-07 19:36 ` Mauro Carvalho Chehab
@ 2008-05-08 10:33 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2008-05-08 10:33 UTC (permalink / raw
To: Mauro Carvalho Chehab; +Cc: Ingo Molnar, linux-kernel
At Wed, 7 May 2008 16:36:28 -0300,
Mauro Carvalho Chehab wrote:
>
> On Wed, 30 Apr 2008 12:41:52 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
>
> Takashi,
>
> I'm assuming that you're handing this issue, right?
Yes, and it was already fixed on Linus git tree.
The selects are converted to depend.
> > > Index: linux/sound/pci/Kconfig
> > > ===================================================================
> > > --- linux.orig/sound/pci/Kconfig
> > > +++ linux/sound/pci/Kconfig
> > > @@ -529,6 +529,7 @@ config SND_FM801_TEA575X
> > > depends on SND_FM801_TEA575X_BOOL
> > > default SND_FM801
> > > select VIDEO_V4L1
> > > + select VIDEO_V4L1_COMPAT
> > > select VIDEO_DEV
>
> Hmm... VIDEO_V4L1 where renamed as VIDEO_ALLOW_V4L1. Probably, this is what's
> broken for SND_FM801_TEA575X.
Partly yes.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-08 10:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-29 20:46 [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug Ingo Molnar
2008-04-30 10:41 ` Takashi Iwai
2008-05-07 19:36 ` Mauro Carvalho Chehab
2008-05-08 10:33 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.